Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Multiple Datasource Test] Add test for error_menu, item, data_source_multi_selectable #6768

Merged
merged 2 commits into from
May 16, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d920951 from #6752.

…_multi_selectable (#6752)

* add test for data_source_error_menu, data_source_item, data_source_multi_selectable

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Changeset file for PR #6752 created/updated

* add content verify in test

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit d920951)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.59%. Comparing base (45d9e6c) to head (045ebc0).

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #6768   +/-   ##
=======================================
  Coverage   67.58%   67.59%           
=======================================
  Files        3427     3427           
  Lines       67352    67352           
  Branches    10982    10982           
=======================================
+ Hits        45521    45526    +5     
+ Misses      19164    19160    -4     
+ Partials     2667     2666    -1     
Flag Coverage Δ
Linux_1 33.07% <ø> (ø)
Linux_2 55.16% <ø> (ø)
Linux_3 45.20% <ø> (+0.01%) ⬆️
Linux_4 34.87% <ø> (ø)
Windows_1 33.10% <ø> (ø)
Windows_2 55.13% <ø> (ø)
Windows_3 45.21% <ø> (+0.02%) ⬆️
Windows_4 34.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZilongX ZilongX requested a review from zhyuanqi as a code owner May 15, 2024 22:15
@ZilongX
Copy link
Collaborator

ZilongX commented May 15, 2024

pick up latest changes from 2.x branch

@BionIT BionIT merged commit ee31ca8 into 2.x May 16, 2024
66 of 67 checks passed
@github-actions github-actions bot deleted the backport/backport-6752-to-2.x branch May 16, 2024 20:50
@zhongnansu zhongnansu added the multiple datasource multiple datasource project label Jun 10, 2024
@zhyuanqi zhyuanqi added the test label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports multiple datasource multiple datasource project test v2.15.0 valued-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants