-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: register right navigation for dev tool only when console is enabled #6701
Conversation
Signed-off-by: tygao <tygao@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6701 +/- ##
==========================================
- Coverage 67.70% 67.69% -0.02%
==========================================
Files 3417 3417
Lines 66922 66922
Branches 10888 10888
==========================================
- Hits 45310 45303 -7
- Misses 18966 18970 +4
- Partials 2646 2649 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nice! @raintygao thanks for the quick fix. |
@kavilla I think the latest feedback is when we start the dashboard |
…led (opensearch-project#6701) Signed-off-by: tygao <tygao@amazon.com>
Description
register right navigation for dev tool only when console is enabled
Screenshot
console is disabled
console is enabled
Testing the changes
yarn start --console.enabled=false
, dev tool and top right navigation won't be registered.yarn start
, dev tool and top right navigation will both be registered.Changelog
Check List
yarn test:jest
yarn test:jest_integration