fix: register right navigation for dev tool only when console is enabled #6701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <tygao@amazon.com>
raintygao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
github-actions
bot
added
valued-contributor
Skip-Changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6701 +/- ##
==========================================
- Coverage 67.70% 67.69% -0.02%
==========================================
Files 3417 3417
Lines 66922 66922
Branches 10888 10888
==========================================
- Hits 45310 45303 -7
- Misses 18966 18970 +4
- Partials 2646 2649 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kavilla
approved these changes
May 2, 2024
|
nice! @raintygao thanks for the quick fix. |
ananzh
approved these changes
May 2, 2024
|
@kavilla I think the latest feedback is when we start the dashboard |
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jun 3, 2024
…led (opensearch-project#6701) Signed-off-by: tygao <tygao@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
register right navigation for dev tool only when console is enabled
Screenshot
console is disabled
console is enabled
Testing the changes
yarn start --console.enabled=false, dev tool and top right navigation won't be registered.yarn start, dev tool and top right navigation will both be registered.Changelog
Check List
yarn test:jestyarn test:jest_integration