-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Workspace] Delete saved objects by workspace #6424
[Backport 2.x] [Workspace] Delete saved objects by workspace #6424
Conversation
* [API] Delete saved objects by workspace (opensearch-project#216) * Delete saved objects by workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> fix osd boostrap Signed-off-by: Hailong Cui <ihailong@amazon.com> * add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix can't delete workspace due to invalid permission Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> * update test case Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add change log Signed-off-by: Hailong Cui <ihailong@amazon.com> * update change log format Signed-off-by: Hailong Cui <ihailong@amazon.com> * update method comments to make it more clear Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 735424b)
Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please make sure all the flows pass.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6424 +/- ##
==========================================
- Coverage 55.53% 54.73% -0.81%
==========================================
Files 1196 2269 +1073
Lines 24167 44436 +20269
Branches 4063 8230 +4167
==========================================
+ Hits 13422 24323 +10901
- Misses 10108 18362 +8254
- Partials 637 1751 +1114
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ZilongX could you help to review the backport PR to 2.x? |
code coverage failed, and can we check? @Hailong-am |
by looking at the coverage report https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/6424/blob/src/core/server/saved_objects/service/lib/repository.ts, it looks like whole file is not covered, And we do have unit test to cover the change. It might be something wrong with collecting coverage from test run. |
backport 735424b from #6013