[Backport 2.x] [Workspace] Delete saved objects by workspace #6424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [API] Delete saved objects by workspace (opensearch-project#216) * Delete saved objects by workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> fix osd boostrap Signed-off-by: Hailong Cui <ihailong@amazon.com> * add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix can't delete workspace due to invalid permission Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> * update test case Signed-off-by: Hailong Cui <ihailong@amazon.com> * Add change log Signed-off-by: Hailong Cui <ihailong@amazon.com> * update change log format Signed-off-by: Hailong Cui <ihailong@amazon.com> * update method comments to make it more clear Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 735424b)
Hailong-am
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
Hailong-am
changed the title
Hailong-am
changed the title
SuZhou-Joe
added
autocut
SuZhou-Joe
reviewed
Apr 12, 2024
Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com>
SuZhou-Joe
approved these changes
Apr 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6424 +/- ##
==========================================
- Coverage 55.53% 54.73% -0.81%
==========================================
Files 1196 2269 +1073
Lines 24167 44436 +20269
Branches 4063 8230 +4167
==========================================
+ Hits 13422 24323 +10901
- Misses 10108 18362 +8254
- Partials 637 1751 +1114
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@ZilongX could you help to review the backport PR to 2.x? |
BionIT
approved these changes
Apr 12, 2024
|
code coverage failed, and can we check? @Hailong-am |
by looking at the coverage report https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/6424/blob/src/core/server/saved_objects/service/lib/repository.ts, it looks like whole file is not covered, And we do have unit test to cover the change. It might be something wrong with collecting coverage from test run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport 735424b from #6013