Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add default icon for selectable component and make sure the default datasource shows automatically #6346

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 726fb0e from #6327.

…atasource shows automatically (#6327)

Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com>
(cherry picked from commit 726fb0e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 67.34%. Comparing base (f838b25) to head (cd93ed2).

Files Patch % Lines
.../data_source_selectable/data_source_selectable.tsx 80.76% 3 Missing and 2 partials ⚠️
...rc/plugins/data_source_management/public/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #6346      +/-   ##
==========================================
- Coverage   67.34%   67.34%   -0.01%     
==========================================
  Files        3344     3344              
  Lines       64867    64874       +7     
  Branches    10395    10396       +1     
==========================================
+ Hits        43684    43687       +3     
- Misses      18654    18658       +4     
  Partials     2529     2529              
Flag Coverage Δ
Linux_1 31.30% <ø> (ø)
Linux_2 55.39% <ø> (ø)
Linux_3 45.10% <78.57%> (+0.01%) ⬆️
Linux_4 ?
Windows_1 31.33% <ø> (ø)
Windows_2 55.35% <ø> (ø)
Windows_3 45.10% <78.57%> (+<0.01%) ⬆️
Windows_4 35.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bandinib-amzn bandinib-amzn merged commit 88ab834 into 2.x Apr 4, 2024
90 of 92 checks passed
@github-actions github-actions bot deleted the backport/backport-6327-to-2.x branch April 4, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports multiple datasource multiple datasource project repeat-contributor v2.14.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants