Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Tests] set legacy browser warning #6250

Merged
merged 3 commits into from
Mar 23, 2024
Merged

[CI][Tests] set legacy browser warning #6250

merged 3 commits into from
Mar 23, 2024

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 22, 2024

Description

Setting legacy browser when running Cypress tests.

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@kavilla
[CI][Tests] set legacy browser warning
2b85ae9 
Setting legacy browser when running Cypress tests.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla @seraphjiang
Update .github/workflows/cypress_workflow.yml
5185273 
Co-authored-by: Huan Jiang <seraphjiang@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.32%. Comparing base (902e216) to head (d49ee2b).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6250      +/-   ##
==========================================
- Coverage   67.34%   67.32%   -0.03%     
==========================================
  Files        3352     3352              
  Lines       65080    65080              
  Branches    10485    10485              
==========================================
- Hits        43829    43814      -15     
- Misses      18699    18712      +13     
- Partials     2552     2554       +2
Flag Coverage Δ
Linux_1 31.82% <ø> (ø)
Linux_2 55.57% <ø> (ø)
Linux_3 44.73% <ø> (-0.02%) ⬇️
Linux_4 35.03% <ø> (ø)
Windows_1 40.00% <ø> (+8.15%) ⬆️
Windows_2 55.53% <ø> (ø)
Windows_3 44.74% <ø> (ø)
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla
switch to false
d49ee2b 
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@ashwin-pc ashwin-pc added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Mar 23, 2024
@ashwin-pc ashwin-pc merged commit 27d73ab into opensearch-project:main Mar 23, 2024
74 of 77 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 23, 2024
@github-actions @seraphjiang
[CI][Tests] set legacy browser warning (#6250)
916aeda 
* [CI][Tests] set legacy browser warning

Setting legacy browser when running Cypress tests.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Update .github/workflows/cypress_workflow.yml

Co-authored-by: Huan Jiang <seraphjiang@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* switch to false

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Huan Jiang <seraphjiang@gmail.com>
(cherry picked from commit 27d73ab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 23, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 23, 2024
@github-actions @seraphjiang
[CI][Tests] set legacy browser warning (#6250)
f4e31ac 
* [CI][Tests] set legacy browser warning

Setting legacy browser when running Cypress tests.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Update .github/workflows/cypress_workflow.yml

Co-authored-by: Huan Jiang <seraphjiang@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* switch to false

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Huan Jiang <seraphjiang@gmail.com>
(cherry picked from commit 27d73ab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 23, 2024
Merged
ananzh pushed a commit that referenced this pull request Apr 12, 2024
@opensearch-trigger-bot @github-actions @seraphjiang
[CI][Tests] set legacy browser warning (#6250) (#6251)
31f6376 
* [CI][Tests] set legacy browser warning
Setting legacy browser when running Cypress tests.
* Update .github/workflows/cypress_workflow.yml
* switch to false



---------



(cherry picked from commit 27d73ab)

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Huan Jiang <seraphjiang@gmail.com>
ananzh pushed a commit that referenced this pull request Apr 12, 2024
@opensearch-trigger-bot @github-actions @seraphjiang
[CI][Tests] set legacy browser warning (#6250) (#6252)
1798b65 
* [CI][Tests] set legacy browser warning
Setting legacy browser when running Cypress tests.
* Update .github/workflows/cypress_workflow.yml
* switch to false


---------

(cherry picked from commit 27d73ab)

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Huan Jiang <seraphjiang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seraphjiang seraphjiang seraphjiang left review comments

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.13 distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kavilla @seraphjiang @AMoo-Miki @ashwin-pc