-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][Tests] set legacy browser warning #6250
Merged
ashwin-pc
merged 3 commits into
opensearch-project:main
from
kavilla:kavilla/verify_csp_warn_legacy
Mar 23, 2024
Merged
[CI][Tests] set legacy browser warning #6250
ashwin-pc
merged 3 commits into
opensearch-project:main
from
kavilla:kavilla/verify_csp_warn_legacy
Mar 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting legacy browser when running Cypress tests. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
requested review from
ananzh,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
March 22, 2024 22:13
seraphjiang
reviewed
Mar 22, 2024
Co-authored-by: Huan Jiang <seraphjiang@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6250 +/- ##
==========================================
- Coverage 67.34% 67.32% -0.03%
==========================================
Files 3352 3352
Lines 65080 65080
Branches 10485 10485
==========================================
- Hits 43829 43814 -15
- Misses 18699 18712 +13
- Partials 2552 2554 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
AMoo-Miki
approved these changes
Mar 22, 2024
ashwin-pc
approved these changes
Mar 23, 2024
ashwin-pc
added
the
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
label
Mar 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
* [CI][Tests] set legacy browser warning Setting legacy browser when running Cypress tests. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Update .github/workflows/cypress_workflow.yml Co-authored-by: Huan Jiang <seraphjiang@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * switch to false Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Huan Jiang <seraphjiang@gmail.com> (cherry picked from commit 27d73ab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
* [CI][Tests] set legacy browser warning Setting legacy browser when running Cypress tests. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Update .github/workflows/cypress_workflow.yml Co-authored-by: Huan Jiang <seraphjiang@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * switch to false Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Huan Jiang <seraphjiang@gmail.com> (cherry picked from commit 27d73ab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh
pushed a commit
that referenced
this pull request
Apr 12, 2024
* [CI][Tests] set legacy browser warning Setting legacy browser when running Cypress tests. * Update .github/workflows/cypress_workflow.yml * switch to false --------- (cherry picked from commit 27d73ab) Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Huan Jiang <seraphjiang@gmail.com>
ananzh
pushed a commit
that referenced
this pull request
Apr 12, 2024
* [CI][Tests] set legacy browser warning Setting legacy browser when running Cypress tests. * Update .github/workflows/cypress_workflow.yml * switch to false --------- (cherry picked from commit 27d73ab) Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Huan Jiang <seraphjiang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
backport 2.13
distinguished-contributor
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting legacy browser when running Cypress tests.
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration