Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix broken links in package.json in opensearch-eslint-config-opensearch-dashboards #605

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jul 8, 2021

Description

/packages/opensearch-eslint-config-opensearch-dashboards/package.json
has broken homepage and bug report links. This PR fixes these two links.

Partically Resolved:

#592

Signed-off-by: Anan Zhuang ananzh@amazon.com

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@ananzh ananzh added bug Something isn't working v1.0.0 labels Jul 8, 2021
@ananzh ananzh requested review from tmarkley, ahopp and kavilla July 8, 2021 21:31
@ananzh ananzh self-assigned this Jul 8, 2021
@ananzh ananzh force-pushed the fix_packagefile_elasticeslintconfigkibana branch from 4d76e6b to 29c18f2 Compare July 8, 2021 21:32
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 29c18f2

@ananzh ananzh force-pushed the fix_packagefile_elasticeslintconfigkibana branch from 29c18f2 to fcfe830 Compare July 8, 2021 21:37
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed fcfe830

@ananzh ananzh force-pushed the fix_packagefile_elasticeslintconfigkibana branch from fcfe830 to 5cb95de Compare July 8, 2021 22:13
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 5cb95de

Both package.json and README.md in
/packages/opensearch-eslint-config-opensearch-dashboards
have some broken links or old concepts. This PR fixes these two files.

Partically Resolved:
opensearch-project#592

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh force-pushed the fix_packagefile_elasticeslintconfigkibana branch from 5cb95de to f50ebda Compare July 9, 2021 02:17
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed f50ebda

@@ -14,9 +14,9 @@
"author": "Spencer Alger <email@spalger.com>",
"license": "Apache-2.0",
"bugs": {
"url": "https://github.com/opensearch-project/OpenSearch-Dashboards/tree/master/packages/elastic-eslint-config-kibana"
"url": "https://github.com/opensearch-project/OpenSearch-Dashboards/issues"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good choice!

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Thanks for the changes.

@mihirsoni mihirsoni merged commit 877521c into opensearch-project:main Jul 9, 2021
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 9, 2021
Both package.json and README.md in
/packages/opensearch-eslint-config-opensearch-dashboards
have some broken links or old concepts. This PR fixes these two files.

Partically Resolved:
opensearch-project#592

Backport PR:
opensearch-project#605

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 9, 2021
Both package.json and README.md in
/packages/opensearch-eslint-config-opensearch-dashboards
have some broken links or old concepts. This PR fixes these two files.

Partically Resolved:
opensearch-project#592

Backport PR:
opensearch-project#605

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this pull request Jul 11, 2021
#627)

Both package.json and README.md in
/packages/opensearch-eslint-config-opensearch-dashboards
have some broken links or old concepts. This PR fixes these two files.

Partically Resolved:
#592

Backport PR:
#605

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this pull request Jul 11, 2021
#626)

Both package.json and README.md in
/packages/opensearch-eslint-config-opensearch-dashboards
have some broken links or old concepts. This PR fixes these two files.

Partically Resolved:
#592

Backport PR:
#605

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh deleted the fix_packagefile_elasticeslintconfigkibana branch February 23, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants