Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix overflow of the expanded document #5788

Merged
merged 2 commits into from
Feb 2, 2024
Merged

[Discover] Fix overflow of the expanded document #5788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bbcde1
Fix vertical alignment of expand details button
AMoo-Miki Feb 2, 2024
ee23011
Fix overflow problem of detailed doc
AMoo-Miki Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/plugins/discover/public/application/components/default_discover_table/_table_cell.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,13 @@
border-top: none !important;
}

.osdDocTableCell__toggleDetails {
padding: 7px 0 0 4px;
// stylelint-disable-next-line @osd/stylelint/no_modifying_global_selectors
.euiFlexItem.osdDocTable__detailsIconContainer {
margin-right: 0;
}

.osd-table td.osdDocTableCell__toggleDetails {
padding: 5px 0 0 4px;
}

/**
Expand Down
8 changes: 4 additions & 4 deletions src/plugins/discover/public/application/components/default_discover_table/table_rows.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,9 @@ export const TableRow = ({

const expandedTableRow = (
<tr key={'x' + row._id}>
<td className="osdDocTable__detailsParent" colSpan={columnIds.length + 2}>
<EuiFlexGroup>
<EuiFlexItem grow={false}>
<td className="osdDocTable__detailsParent" colSpan={columnIds.length + 1}>
<EuiFlexGroup gutterSize="m" alignItems="center">
<EuiFlexItem grow={false} className="osdDocTable__detailsIconContainer">
<EuiIcon type="folderOpen" />
</EuiFlexItem>
<EuiFlexItem>
Expand All @@ -150,7 +150,7 @@ export const TableRow = ({
<DocViewerLinks hit={row} indexPattern={indexPattern} columns={columns} />
</EuiFlexItem>
</EuiFlexGroup>
<EuiFlexGroup>
<EuiFlexGroup gutterSize="m">
<EuiFlexItem>
<DocViewer
hit={row}
Expand Down
Loading