Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look and feel enhancements - Batch 1 #5766

Conversation

AMoo-Miki
Copy link
Collaborator

Description

[Discover] Vertically align expansion arrows
[Discover] Clamp the amount of data shown in a row
[Discover] Display filter buttons at top right of the cell
[Discover] Prevent wrapping of date fields
Use ouiCodeFont in Discover and reduce text size
[Discover] Vertically align source cells with others
Revert the breadcrumb of Discover to be a link rather than a button
Vertically align the text in osdQueryBar with other elements on the page

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ec8176) 67.02% compared to head (95bcdd4) 67.02%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           feature/table-revert    #5766   +/-   ##
=====================================================
  Coverage                 67.02%   67.02%           
=====================================================
  Files                      3296     3296           
  Lines                     63345    63345           
  Branches                  10089    10089           
=====================================================
  Hits                      42458    42458           
  Misses                    18433    18433           
  Partials                   2454     2454           
Flag Coverage Δ
Linux_1 35.23% <ø> (?)
Linux_2 55.18% <ø> (ø)
Linux_4 35.33% <ø> (ø)
Windows_1 35.26% <ø> (ø)
Windows_2 55.15% <ø> (ø)
Windows_3 43.91% <ø> (ø)
Windows_4 35.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Also:
* adjust the width of non-wrapped cells

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants