[DOCS] Replace settings and help menu links #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing previous upstream references with working links. This does not fully resolve the current issue due to the link being replaced with a temporary link, and the link directing to related documentation if it exists but some do not so it sends it to the basic OpenSearch Dashboards documentation which is a bad experience but better than a 404. Partially resolves: opensearch-project#335 Will track replacement with: opensearch-project#335 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
|
✅ DCO Check Passed 2980278 |
ananzh
reviewed
Jun 29, 2021
good point, tbh we probably don't have any analytics anyways so it can all be noreferrer, i can create an issue and update it in a subsequent PR post GA? |
tmarkley
approved these changes
Jun 29, 2021
|
|
kavilla
added a commit
that referenced
this pull request
Jun 30, 2021
Replacing previous upstream references with working links. This does not fully resolve the current issue due to the link being replaced with a temporary link, and the link directing to related documentation if it exists but some do not so it sends it to the basic OpenSearch Dashboards documentation which is a bad experience but better than a 404. Partially resolves: #335 Will track replacement with: #335 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
that referenced
this pull request
Jun 30, 2021
Replacing previous upstream references with working links. This does not fully resolve the current issue due to the link being replaced with a temporary link, and the link directing to related documentation if it exists but some do not so it sends it to the basic OpenSearch Dashboards documentation which is a bad experience but better than a 404. Partially resolves: #335 Will track replacement with: #335 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing previous upstream references with working links.
This does not fully resolve the current issue due to the link
being replaced with a temporary link, and the link directing
to related documentation if it exists but some do not so it
sends it to the basic OpenSearch Dashboards documentation which
is a bad experience but better than a 404.
Will track replacement with:
#335
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issues Resolved
Partial: #335
Check List