Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Add @SuZhou-Joe as a maintainer #5594

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Dec 12, 2023

@kavilla kavilla changed the title [Admin] Add suzhou-joe as a maintainer [Admin] Add @SuZhou-Joe as a maintainer Dec 12, 2023
@kavilla kavilla marked this pull request as ready for review December 12, 2023 05:36
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (805400d) 67.00% compared to head (859b095) 66.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5594      +/-   ##
==========================================
- Coverage   67.00%   66.98%   -0.02%     
==========================================
  Files        3293     3293              
  Lines       63287    63287              
  Branches    10062    10062              
==========================================
- Hits        42406    42394      -12     
- Misses      18441    18453      +12     
  Partials     2440     2440              
Flag Coverage Δ
Linux_1 35.24% <ø> (ø)
Linux_2 55.21% <ø> (ø)
Linux_3 43.79% <ø> (+0.01%) ⬆️
Linux_4 35.34% <ø> (ø)
Windows_1 35.27% <ø> (-0.04%) ⬇️
Windows_2 55.17% <ø> (ø)
Windows_3 43.80% <ø> (ø)
Windows_4 35.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla
Copy link
Member Author

kavilla commented Dec 12, 2023

@opensearch-project/admin, please add @SuZhou-Joe as a maintainer to OpenSearch Dashboards. They were nominated and approved by the current maintainers with no vetoes. @SuZhou-Joe has accepted and approved.

@bbarani
Copy link
Member

bbarani commented Dec 12, 2023

SuZhou-Joe has been added as one of the maintainer of this repo.

@AMoo-Miki AMoo-Miki merged commit f27a031 into opensearch-project:main Dec 12, 2023
97 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-1.x
# Create a new branch
git switch --create backport/backport-5594-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f27a031d7fe01919ef474bd2a9e3cb465a8fa9fd
# Push it to GitHub
git push --set-upstream origin backport/backport-5594-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-5594-to-1.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-5594-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f27a031d7fe01919ef474bd2a9e3cb465a8fa9fd
# Push it to GitHub
git push --set-upstream origin backport/backport-5594-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5594-to-2.x.

ananzh added a commit that referenced this pull request Dec 13, 2023
Backport PR
#5594

Updates MAINTAINERS.md and .github/CODEOWNERS.

Here are their current merge contributions, total contributions, and issues:
https://github.com/opensearch-project/OpenSearch-Dashboards/pulls?q=is%3Apr+is%3Amerged+author%3Asuzhou-joe+
https://github.com/opensearch-project/OpenSearch-Dashboards/pulls?q=is%3Apr+author%3Asuzhou-joe+
https://github.com/opensearch-project/OpenSearch-Dashboards/issues?q=is%3Aissue+suzhou-joe+is%3Aopen

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this pull request Jan 3, 2024
Backport PR
#5594

Updates MAINTAINERS.md and .github/CODEOWNERS.

Here are their current merge contributions, total contributions, and issues:
https://github.com/opensearch-project/OpenSearch-Dashboards/pulls?q=is%3Apr+is%3Amerged+author%3Asuzhou-joe+
https://github.com/opensearch-project/OpenSearch-Dashboards/pulls?q=is%3Apr+author%3Asuzhou-joe+
https://github.com/opensearch-project/OpenSearch-Dashboards/issues?q=is%3Aissue+suzhou-joe+is%3Aopen

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants