Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Discover 2.0] fixes add filter and dismissible callout #5032

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b9b2b79 from #5029.

* fixes add filter and dismissible callout

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* fixes filters applying when loading a saved search

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit b9b2b79)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #5032 (fbed05d) into 2.x (ae37ab8) will decrease coverage by 0.01%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##              2.x    #5032      +/-   ##
==========================================
- Coverage   66.48%   66.47%   -0.01%     
==========================================
  Files        3402     3402              
  Lines       64979    64982       +3     
  Branches    10374    10374              
==========================================
- Hits        43200    43199       -1     
- Misses      19216    19219       +3     
- Partials     2563     2564       +1     
Flag Coverage Δ
Linux_1 34.87% <ø> (ø)
Linux_2 55.19% <ø> (ø)
Linux_3 44.38% <20.00%> (-0.01%) ⬇️
Linux_4 35.05% <ø> (ø)
Windows_1 34.88% <ø> (ø)
Windows_2 55.15% <ø> (ø)
Windows_3 44.38% <20.00%> (-0.01%) ⬇️
Windows_4 35.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...pplication/view_components/utils/filter_columns.ts 100.00% <ø> (ø)
.../public/application/components/discover_legacy.tsx 2.38% <20.00%> (+2.38%) ⬆️

... and 1 file with indirect coverage changes

@kavilla kavilla merged commit d8dc7f8 into 2.x Sep 16, 2023
73 of 75 checks passed
@github-actions github-actions bot deleted the backport/backport-5029-to-2.x branch September 16, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants