Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer] Fix breadcrumb for data explorer #4856

Merged

Conversation

abbyhu2000
Copy link
Member

@abbyhu2000 abbyhu2000 commented Aug 30, 2023

Description

Fix breadcrumb for data explorer.

Issues Resolved

resolves #4779

Screenshot

Screen.Recording.2023-08-30.at.10.20.31.AM.mov

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #4856 (b5d1e43) into main (03ae2bd) will decrease coverage by 0.03%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4856      +/-   ##
==========================================
- Coverage   66.46%   66.44%   -0.03%     
==========================================
  Files        3390     3396       +6     
  Lines       64742    64865     +123     
  Branches    10312    10355      +43     
==========================================
+ Hits        43030    43097      +67     
- Misses      19169    19210      +41     
- Partials     2543     2558      +15     
Flag Coverage Δ
Linux_1 34.85% <ø> (-0.02%) ⬇️
Linux_2 55.15% <ø> (ø)
Linux_3 44.24% <ø> (+0.06%) ⬆️
Linux_4 35.04% <ø> (ø)
Windows_1 34.87% <ø> (-0.02%) ⬇️
Windows_2 55.12% <ø> (ø)
Windows_3 44.24% <ø> (+0.05%) ⬆️
Windows_4 35.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

CHANGELOG.md Outdated
@@ -226,6 +226,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Add support for Node.js >=14.20.1 <19 ([#4071](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4071))
- Bundle Node.js 14 as a fallback for operating systems that cannot run Node.js 18 ([#4151](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4151))
- Enhance grouping for context menus ([#3924](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3924))
- [Data Explorer] Fix breadcrumb for data explorer ([#4856](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4856))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip changelog for these changes since Data explorer is going out for the first time this release anyways

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@abbyhu2000 abbyhu2000 added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Aug 30, 2023
@ananzh ananzh merged commit 7faa088 into opensearch-project:main Aug 30, 2023
55 of 57 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-4856-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7faa088c1a23cf4a47c8148919c5ea99d35d5a03
# Push it to GitHub
git push --set-upstream origin backport/backport-4856-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4856-to-2.x.

ashwin-pc pushed a commit to ashwin-pc/OpenSearch-Dashboards that referenced this pull request Aug 31, 2023
…4856)

* add breadcrumb

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 7faa088)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x data explorer Issues related to the Data Explorer project distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data Explorer] Wrong breadcrumb for discover 2.0
3 participants