-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Explorer][Discover 2.0] Add missing change interval on TimeChart and improve fetch #4850
Merged
ananzh
merged 1 commit into
opensearch-project:main
from
ananzh:discover-fix-chart-interval
Aug 30, 2023
Merged
[Data Explorer][Discover 2.0] Add missing change interval on TimeChart and improve fetch #4850
ananzh
merged 1 commit into
opensearch-project:main
from
ananzh:discover-fix-chart-interval
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
added
bug
Something isn't working
discover
for discover reinvent
data explorer
Issues related to the Data Explorer project
v2.10.0
labels
Aug 29, 2023
Codecov Report
@@ Coverage Diff @@
## main #4850 +/- ##
==========================================
- Coverage 66.46% 66.45% -0.01%
==========================================
Files 3390 3390
Lines 64742 64743 +1
Branches 10312 10312
==========================================
- Hits 43030 43028 -2
- Misses 19169 19171 +2
- Partials 2543 2544 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…t and improve fetch Issue Resolve opensearch-project#4847 Signed-off-by: ananzh <ananzh@amazon.com>
ananzh
force-pushed
the
discover-fix-chart-interval
branch
from
August 30, 2023 16:48
42a3123
to
e07ae87
Compare
ananzh
requested review from
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
August 30, 2023 16:48
ashwin-pc
added
the
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
label
Aug 30, 2023
ashwin-pc
approved these changes
Aug 30, 2023
abbyhu2000
approved these changes
Aug 30, 2023
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-4850-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a239fc204d9b505e800054a7eae27d2ebe939d00
# Push it to GitHub
git push --set-upstream origin backport/backport-4850-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
ashwin-pc
pushed a commit
to ashwin-pc/OpenSearch-Dashboards
that referenced
this pull request
Aug 31, 2023
…t and improve fetch (opensearch-project#4850) Issue Resolve opensearch-project#4847 Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit a239fc2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
bug
Something isn't working
data explorer
Issues related to the Data Explorer project
discover
for discover reinvent
distinguished-contributor
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
v2.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is blocked by #4806
We currently decide to move from feature branch to main for all following fixes. After #4806 is merged, I will rebase the PR and remove draft.
Issues Resolved
#4847
Description
Allow discover 2.0 histogram to update according to interval change.
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr