[CVE-2023-26136] [1.3] Resolve tough-cookie to 4.1.3 #4682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Romero <rmerqg@amazon.com>
joshuarrrr
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Partial backport of opensearch-project#1113 Signed-off-by: Josh Romero <rmerqg@amazon.com>
AMoo-Miki
approved these changes
Aug 5, 2023
Codecov Report
@@ Coverage Diff @@
## 1.3 #4682 +/- ##
==========================================
- Coverage 67.50% 67.50% -0.01%
==========================================
Files 3044 3044
Lines 58692 58692
Branches 8902 8902
==========================================
- Hits 39621 39619 -2
- Misses 16923 16925 +2
Partials 2148 2148
Flags with carried forward coverage won't be shown. Click here to find out more. |
kavilla
approved these changes
Aug 7, 2023
|
For reference, the test updates were lifted from #1113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes CVE-2023-26136.
Because
tough-cookieis only a nested dependency, added a resolution.Subsequently added it as a direct dev dependency so we could update the session cookie tests.
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr