[Backport 2.x] [Stylelint] Add invalid properties rule #4441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add invalid properties rule Signed-off-by: Matt Provost <provomat@amazon.com> * Update changelog Signed-off-by: Matt Provost <provomat@amazon.com> * Rename old variable Signed-off-by: Matt Provost <provomat@amazon.com> * Add types for configs Signed-off-by: Matt Provost <provomat@amazon.com> * Rename rule to no_restricted_properties Signed-off-by: Matt Provost <provomat@amazon.com> * Refactor duplicate functions into generic one Signed-off-by: Matt Provost <provomat@amazon.com> * Add type definitions Signed-off-by: Matt Provost <provomat@amazon.com> * Add some documentation about supported config types Signed-off-by: Matt Provost <provomat@amazon.com> * Update changelog Signed-off-by: Matt Provost <provomat@amazon.com> * Optchain instead of unwrapping source file Signed-off-by: Matt Provost <provomat@amazon.com> --------- Signed-off-by: Matt Provost <provomat@amazon.com> (cherry picked from commit d285ecb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon and
kristenTian
as code owners
opensearch-trigger-bot
bot
added
the
autocut
opensearch-trigger-bot
bot
requested review from
ZilongX and
Flyingliuhub
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #4441 +/- ##
==========================================
+ Coverage 66.36% 66.42% +0.05%
==========================================
Files 3246 3246
Lines 62443 62443
Branches 9671 9671
==========================================
+ Hits 41443 41477 +34
+ Misses 18649 18621 -28
+ Partials 2351 2345 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
joshuarrrr
approved these changes
Jun 29, 2023
AMoo-Miki
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport d285ecb from #4374.