Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [CCI] Fix bottom bar visibility using createPortal #4043

Merged
merged 2 commits into from
May 17, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 87e7951 from #3978.

Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Andrey Myssak <andreymyssak@gmail.com>
(cherry picked from commit 87e7951)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #4043 (b93815f) into 2.x (afdb244) will decrease coverage by 0.05%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##              2.x    #4043      +/-   ##
==========================================
- Coverage   66.44%   66.39%   -0.05%     
==========================================
  Files        3229     3229              
  Lines       62045    62045              
  Branches     9597     9596       -1     
==========================================
- Hits        41226    41195      -31     
- Misses      18517    18518       +1     
- Partials     2302     2332      +30     
Flag Coverage Δ
Linux ?
Windows 66.39% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ngs/public/management_app/components/form/form.tsx 69.69% <66.66%> (-1.02%) ⬇️
src/core/public/rendering/app_containers.tsx 100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

@abbyhu2000 abbyhu2000 added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label May 16, 2023
@abbyhu2000 abbyhu2000 merged commit e455e48 into 2.x May 17, 2023
@github-actions github-actions bot deleted the backport/backport-3978-to-2.x branch May 17, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants