Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an achievement badger to the PR #3721

Merged
merged 4 commits into from
Apr 3, 2023

Conversation

ashwin-pc
Copy link
Member

@ashwin-pc ashwin-pc commented Mar 29, 2023

Description

Adding the achievement workflow for PR's

Issues Resolved

#3708

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@ashwin-pc ashwin-pc requested a review from a team as a code owner March 29, 2023 16:31
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@ashwin-pc ashwin-pc added the ci label Mar 29, 2023
@kavilla kavilla linked an issue Mar 29, 2023 that may be closed by this pull request
permissions:
pull-requests: write
steps:
- uses: aws-github-ops/github-merit-badger@v0.0.98
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be allowed for the org?

i know in the past if the github action was not explicitly defined at the org wide settings that it will fail (at least for write permissions)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its the same as the one thats already applied to OpenSearch and opensearch-build repos. They already have this in place and are using it. so i think its safe to assume that it will work

@ashwin-pc ashwin-pc self-assigned this Mar 29, 2023
CHANGELOG.md Outdated
@@ -123,6 +123,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Fix detection of Chrome's version on Darwin during CI ([#3296](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3296))
- Upgrade yarn version to be compatible with @openearch-project/opensearch ([#3443](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3443))
- [CI] Reduce redundancy by using matrix strategy on Windows and Linux workflows ([#3514](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3514))
- Adds achievement workflow ([#3721](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3721))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Adds achievement workflow ([#3721](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3721))
- Add an achievement badger to the PR workflow ([#3721](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3721))

@ashwin-pc ashwin-pc changed the title Adds achievement workflow Add an achievement badger to the PR Mar 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Merging #3721 (1899c85) into main (53047b6) will decrease coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3721      +/-   ##
==========================================
- Coverage   66.45%   66.44%   -0.01%     
==========================================
  Files        3209     3209              
  Lines       61633    61633              
  Branches     9506     9506              
==========================================
- Hits        40960    40954       -6     
- Misses      18396    18400       +4     
- Partials     2277     2279       +2     
Flag Coverage Δ
Linux 66.39% <ø> (-0.01%) ⬇️
Windows 66.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashwin-pc ashwin-pc merged commit 925b96d into opensearch-project:main Apr 3, 2023
vagimeli pushed a commit to vagimeli/OpenSearch-Dashboards that referenced this pull request Apr 4, 2023
* Adds achievement workflow

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Adds changelog entry

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Update CHANGELOG.md based on suggestion

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: vagimeli <vagimeli@amazon.com>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
* Adds achievement workflow

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Adds changelog entry

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Update CHANGELOG.md based on suggestion

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discuss] Achievement badges
5 participants