Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3] [Manual backport 1.x] Updates NOTICE file, adds validation to GitHub CI & Corrects NOTICE f… #3596

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport bf1c65f from #3453.

…CI & Corrects NOTICE f… (#3453)

* Updates NOTICE file, adds validation to GitHub CI (#3051)

* Aligns NOTICE with rules outlined in
opensearch-project/.github#21.
* Adds NOTICE validation to the build and test workflow.
* Fixes product name discrepancies between repository NOTICE file and
the generated NOTICE file for the build.
* Skips template-izing the build and test workflow since that's being
worked on in #2991.

Resolves #765

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>

* Corrects NOTICE file copyright date range (#3308)

* Corrects NOTICE file copyright date range

* Follow-up on #3051

Resolves #765

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Miki <amoo_miki@yahoo.com>

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>

---------

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
Co-authored-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit bf1c65f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@joshuarrrr joshuarrrr added v1.3.10 autocut Skip the changelog verification check on backports labels Mar 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3596 (de0a86e) into 1.3 (d74e0a6) will decrease coverage by 0.04%.
The diff coverage is 12.50%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              1.3    #3596      +/-   ##
==========================================
- Coverage   67.49%   67.45%   -0.04%     
==========================================
  Files        3044     3044              
  Lines       58697    58692       -5     
  Branches     8902     8902              
==========================================
- Hits        39618    39593      -25     
- Misses      16931    16946      +15     
- Partials     2148     2153       +5     
Flag Coverage Δ
Linux 67.45% <12.50%> (+<0.01%) ⬆️
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dev/notice/generate_notice_from_source.ts 11.11% <12.50%> (+4.86%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kavilla kavilla merged commit 3d6b2f6 into 1.3 Mar 13, 2023
@github-actions github-actions bot deleted the backport/backport-3453-to-1.3 branch March 13, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v1.3.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants