Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dev tool console to use opensearch-js client to send request #3544

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Refactor dev tool console to use opensearch-js client to send request #3544

merged 3 commits into from
Mar 21, 2023

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Mar 7, 2023 •
edited
Loading

Description

Refactor dev tool console to use opensearch-js client to send request

Issues Resolved

part of #2699
#3546

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@zhongnansu zhongnansu mentioned this pull request Mar 7, 2023
Closed
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023 •
edited
Loading

Codecov Report

Merging #3544 (9842874) into main (cb472dc) will decrease coverage by 0.02%.
The diff coverage is 70.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3544      +/-   ##
==========================================
- Coverage   66.41%   66.40%   -0.02%     
==========================================
  Files        3209     3208       -1     
  Lines       61617    61593      -24     
  Branches     9504     9502       -2     
==========================================
- Hits        40926    40902      -24     
+ Misses      18412    18410       -2     
- Partials     2279     2281       +2
Flag Coverage Δ
Linux ?
Windows 66.40% <70.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../server/routes/api/console/proxy/create_handler.ts 76.92% <70.00%> (-4.56%) ⬇️

... and 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zhongnansu zhongnansu mentioned this pull request Mar 7, 2023
Closed
@zhongnansu zhongnansu force-pushed the md-dev-tool branch 3 times, most recently from a1a30de to 13c5c57 Compare March 8, 2023 01:47
@zhongnansu zhongnansu changed the title [MD][POC] Refactor dev tool console to use opensearch-js client [Multiple Datasource]Refactor dev tool console to use opensearch-js client to send request Mar 8, 2023
@zhongnansu zhongnansu marked this pull request as ready for review March 8, 2023 05:38
@zhongnansu zhongnansu requested a review from a team as a code owner March 8, 2023 05:38
@zhongnansu zhongnansu added refactor Tech debt related tasks that need refactoring v2.7.0 labels Mar 8, 2023
@zhongnansu zhongnansu changed the title [Multiple Datasource]Refactor dev tool console to use opensearch-js client to send request Refactor dev tool console to use opensearch-js client to send request Mar 8, 2023
@zhongnansu zhongnansu added multiple datasource multiple datasource project backport 2.x labels Mar 8, 2023
kristenTian
kristenTian previously approved these changes Mar 14, 2023
View reviewed changes
kristenTian
kristenTian previously approved these changes Mar 15, 2023
View reviewed changes
@zhongnansu zhongnansu requested review from abbyhu2000 and removed request for kavilla March 20, 2023 22:04
@zhongnansu
- Refactor dev tool console to use opensearch-js client to interact w…
a12418f 
…ith OpenSearch

- Update tests

Signed-off-by: Su <szhongna@amazon.com>
@zhongnansu
reset feature switch
7422ab7 
Signed-off-by: Su <szhongna@amazon.com>
@zhongnansu
address comment
9842874 
Signed-off-by: Su <szhongna@amazon.com>
abbyhu2000
abbyhu2000 approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@abbyhu2000 abbyhu2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the functionalities and LGTM!

@zhongnansu zhongnansu merged commit de06344 into opensearch-project:main Mar 21, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 21, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 21, 2023
@github-actions
Refactor dev tool console to use opensearch-js client to send request (…
980a029 
…#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <szhongna@amazon.com>
(cherry picked from commit de06344)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
kappassov pushed a commit to kappassov/OpenSearch-Dashboards that referenced this pull request Mar 21, 2023
@zhongnansu @kappassov
Refactor dev tool console to use opensearch-js client to send request (…
1d94df4 
…opensearch-project#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <szhongna@amazon.com>
zhongnansu added a commit that referenced this pull request Mar 21, 2023
@opensearch-trigger-bot @github-actions @zhongnansu
[Backport 2.x] Refactor dev tool console to use opensearch-js client …
bde6e5b 
…to send request (#3639)

* Refactor dev tool console to use opensearch-js client to send request (#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <szhongna@amazon.com>
(cherry picked from commit de06344)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

* add changelog

Signed-off-by: Su <szhongna@amazon.com>

---------

Signed-off-by: Su <szhongna@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Su <szhongna@amazon.com>
@abbyhu2000 abbyhu2000 mentioned this pull request Mar 21, 2023
Closed
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Mar 22, 2023
@zhongnansu
Refactor dev tool console to use opensearch-js client to send request (…
2d4eee4 
…opensearch-project#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <szhongna@amazon.com>
abbyhu2000 pushed a commit that referenced this pull request Mar 22, 2023
@kappassov @ananzh
@AMoo-Miki @zhongnansu
[CCI] Adding second command to Install yarn step in Developer Guide (#…
b0146e7 
…3633)

* added prepare command

Signed-off-by: kappassov <abayk0708@gmail.com>

* Use mirrors to download Node.js binaries to escape sporadic 404 errors (#3619)

Issue Resolved:
#3618

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Allow selecting the Node.js binary OSD uses (#3508)

New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD.
* The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary.
* Update `package.json` to replace `node` with `use_node`.
* Update file templates and shell scripts to internally use `use_node`.
* Update the build scripts to copy `use_node` into releases
* Make tests that execute node internally, honor the binary being used.

Signed-off-by: Miki <miki@amazon.com>

* Clean up and rebuild @osd/pm (#3570)

* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <miki@amazon.com>

* Refactor dev tool console to use opensearch-js client to send request (#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <szhongna@amazon.com>

* updates after the 1st review

Signed-off-by: kappassov <abayk0708@gmail.com>

---------

Signed-off-by: kappassov <abayk0708@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Su <szhongna@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 22, 2023
@github-actions @ananzh
@AMoo-Miki @zhongnansu
[CCI] Adding second command to Install yarn step in Developer Guide (#…
a91302d 
…3633)

* added prepare command

Signed-off-by: kappassov <abayk0708@gmail.com>

* Use mirrors to download Node.js binaries to escape sporadic 404 errors (#3619)

Issue Resolved:
#3618

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Allow selecting the Node.js binary OSD uses (#3508)

New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD.
* The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary.
* Update `package.json` to replace `node` with `use_node`.
* Update file templates and shell scripts to internally use `use_node`.
* Update the build scripts to copy `use_node` into releases
* Make tests that execute node internally, honor the binary being used.

Signed-off-by: Miki <miki@amazon.com>

* Clean up and rebuild @osd/pm (#3570)

* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <miki@amazon.com>

* Refactor dev tool console to use opensearch-js client to send request (#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <szhongna@amazon.com>

* updates after the 1st review

Signed-off-by: kappassov <abayk0708@gmail.com>

---------

Signed-off-by: kappassov <abayk0708@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Su <szhongna@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
(cherry picked from commit b0146e7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000 pushed a commit that referenced this pull request Mar 22, 2023
@opensearch-trigger-bot @github-actions
@ananzh @AMoo-Miki @zhongnansu
[CCI] Adding second command to Install yarn step in Developer Guide (#…
3d2082a 
…3633) (#3651)

* added prepare command



* Use mirrors to download Node.js binaries to escape sporadic 404 errors (#3619)

Issue Resolved:
#3618



* Allow selecting the Node.js binary OSD uses (#3508)

New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD.
* The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary.
* Update `package.json` to replace `node` with `use_node`.
* Update file templates and shell scripts to internally use `use_node`.
* Update the build scripts to copy `use_node` into releases
* Make tests that execute node internally, honor the binary being used.



* Clean up and rebuild @osd/pm (#3570)

* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list



* Refactor dev tool console to use opensearch-js client to send request (#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch



* updates after the 1st review



---------








(cherry picked from commit b0146e7)

Signed-off-by: kappassov <abayk0708@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Su <szhongna@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Mar 24, 2023
@kappassov @ananzh
@AMoo-Miki @zhongnansu
[CCI] Adding second command to Install yarn step in Developer Guide (o…
9821c56 
…pensearch-project#3633)

* added prepare command

Signed-off-by: kappassov <abayk0708@gmail.com>

* Use mirrors to download Node.js binaries to escape sporadic 404 errors (opensearch-project#3619)

Issue Resolved:
opensearch-project#3618

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Allow selecting the Node.js binary OSD uses (opensearch-project#3508)

New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD.
* The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary.
* Update `package.json` to replace `node` with `use_node`.
* Update file templates and shell scripts to internally use `use_node`.
* Update the build scripts to copy `use_node` into releases
* Make tests that execute node internally, honor the binary being used.

Signed-off-by: Miki <miki@amazon.com>

* Clean up and rebuild @osd/pm (opensearch-project#3570)

* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <miki@amazon.com>

* Refactor dev tool console to use opensearch-js client to send request (opensearch-project#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <szhongna@amazon.com>

* updates after the 1st review

Signed-off-by: kappassov <abayk0708@gmail.com>

---------

Signed-off-by: kappassov <abayk0708@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Su <szhongna@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
@joshuarrrr joshuarrrr mentioned this pull request Apr 10, 2023
Closed
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@zhongnansu @sikhote
Refactor dev tool console to use opensearch-js client to send request (…
9bdfde6 
…opensearch-project#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <szhongna@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@kappassov @ananzh
@AMoo-Miki @zhongnansu @sikhote
[CCI] Adding second command to Install yarn step in Developer Guide (o…
5c7953a 
…pensearch-project#3633)

* added prepare command

Signed-off-by: kappassov <abayk0708@gmail.com>

* Use mirrors to download Node.js binaries to escape sporadic 404 errors (opensearch-project#3619)

Issue Resolved:
opensearch-project#3618

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Allow selecting the Node.js binary OSD uses (opensearch-project#3508)

New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD.
* The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary.
* Update `package.json` to replace `node` with `use_node`.
* Update file templates and shell scripts to internally use `use_node`.
* Update the build scripts to copy `use_node` into releases
* Make tests that execute node internally, honor the binary being used.

Signed-off-by: Miki <miki@amazon.com>

* Clean up and rebuild @osd/pm (opensearch-project#3570)

* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <miki@amazon.com>

* Refactor dev tool console to use opensearch-js client to send request (opensearch-project#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <szhongna@amazon.com>

* updates after the 1st review

Signed-off-by: kappassov <abayk0708@gmail.com>

---------

Signed-off-by: kappassov <abayk0708@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Su <szhongna@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
@zhongnansu zhongnansu mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hailong-am Hailong-am Hailong-am left review comments

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@kristenTian kristenTian kristenTian approved these changes

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

Assignees

@zhongnansu zhongnansu

Labels
backport 2.x multiple datasource multiple datasource project refactor Tech debt related tasks that need refactoring v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhongnansu @codecov-commenter @AMoo-Miki @abbyhu2000 @kristenTian @Hailong-am