Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.5] [VisBuilder] Fixes pipeline aggs #3242

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c259952 from #3137.

* fixes pipeline aggs in visbuilder

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* adds changelog

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Adds unit tests

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* fixes pipeline aggs in visbuilder

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* adds changelog

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Adds unit tests

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* fixes unit tests

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit c259952)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 10, 2023 23:55
@manasvinibs manasvinibs added v2.5.0 'Issues and PRs related to version v2.5.0' autocut Skip the changelog verification check on backports labels Jan 11, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3242 (e559d03) into 2.5 (6df998c) will increase coverage by 0.06%.
The diff coverage is 34.78%.

@@            Coverage Diff             @@
##              2.5    #3242      +/-   ##
==========================================
+ Coverage   66.49%   66.56%   +0.06%     
==========================================
  Files        3200     3203       +3     
  Lines       61295    61327      +32     
  Branches     9440     9452      +12     
==========================================
+ Hits        40760    40821      +61     
+ Misses      18275    18252      -23     
+ Partials     2260     2254       -6     
Flag Coverage Δ
Linux 66.50% <34.78%> (?)
Windows 66.50% <34.78%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uilder/public/application/components/workspace.tsx 3.57% <0.00%> (-0.43%) ⬇️
...public/application/utils/state_management/store.ts 18.75% <0.00%> (+4.46%) ⬆️
...tion/utils/state_management/visualization_slice.ts 33.33% <0.00%> (-2.78%) ⬇️
...application/utils/use/use_saved_vis_builder_vis.ts 2.56% <0.00%> (+0.12%) ⬆️
...ilder/public/embeddable/vis_builder_embeddable.tsx 0.98% <0.00%> (ø)
...ion/utils/state_management/handlers/parent_aggs.ts 5.88% <5.88%> (ø)
...on/utils/state_management/handlers/editor_state.ts 16.66% <16.66%> (ø)
...plication/utils/state_management/metadata_slice.ts 61.53% <33.33%> (ø)
...pplication/components/data_tab/secondary_panel.tsx 1.96% <50.00%> (ø)
...cation/utils/state_management/redux_persistence.ts 80.00% <100.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@manasvinibs manasvinibs merged commit 97307fd into 2.5 Jan 11, 2023
@github-actions github-actions bot deleted the backport/backport-3137-to-2.5 branch January 11, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants