-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md with the nvm, yarn setup steps #317
Conversation
✅ DCO Check Passed 4c99c9c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !! Thank you.
Thanks for the reviews. Let me know if I need to rebase the branch. I can do it. |
This commit adds the installation steps of yarn and npm in the README.md file before the setup. Signed-off-by: Venu Vardhan Reddy Tekula <venu@bitergia.com>
Oops, I thought of rebasing the branch so that it is easy to merge but it seems all the approved reviews are reverted. 🙁 |
✅ DCO Check Passed e978294 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. Looks good
This commit adds the installation steps of yarn and npm in the README.md file before the setup. Signed-off-by: Venu Vardhan Reddy Tekula <venu@bitergia.com>
* Add workspace overview page (#19) * feat: add workspace overview page Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: move paths to common constants Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add workspace overview item by custom nav in start phase Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: change to currentWorkspace$ in workspace client Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> * restore yml Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Lin Wang <wonglam@amazon.com>
Description
This commit adds the installation steps of yarn and npm in the README.md file before the setup.
Issues Resolved
Closes #270
Check List
@seraphjiang, do you have any suggestions?