Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with the nvm, yarn setup steps #317

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

vchrombie
Copy link
Contributor

Description

This commit adds the installation steps of yarn and npm in the README.md file before the setup.

Issues Resolved

Closes #270

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@seraphjiang, do you have any suggestions?

@odfe-release-bot
Copy link

✅   DCO Check Passed 4c99c9c

ananzh
ananzh previously approved these changes Apr 24, 2021
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you so much!

kavilla
kavilla previously approved these changes Apr 26, 2021
mihirsoni
mihirsoni previously approved these changes Apr 26, 2021
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Thank you.

@vchrombie
Copy link
Contributor Author

Thanks for the reviews. Let me know if I need to rebase the branch. I can do it.

This commit adds the installation steps of yarn and npm
in the README.md file before the setup.

Signed-off-by: Venu Vardhan Reddy Tekula <venu@bitergia.com>
@vchrombie
Copy link
Contributor Author

Oops, I thought of rebasing the branch so that it is easy to merge but it seems all the approved reviews are reverted. 🙁
I'm sorry for the inconvenience. It would be great if you can review it again.

@odfe-release-bot
Copy link

✅   DCO Check Passed e978294

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. Looks good

@kavilla kavilla merged commit af106be into opensearch-project:main Apr 27, 2021
kavilla pushed a commit that referenced this pull request May 21, 2021
This commit adds the installation steps of yarn and npm
in the README.md file before the setup.

Signed-off-by: Venu Vardhan Reddy Tekula <venu@bitergia.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Apr 7, 2024
* Add workspace overview page (#19)

* feat: add workspace overview page

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: move paths to common constants

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add workspace overview item by custom nav in start phase

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: change to currentWorkspace$ in workspace client

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>

* restore yml

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: Lin Wang <wonglam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Improve the get started guidance for developer
6 participants