Renames v7 theme, removes beta theme #3048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Forces the v1 (the old v7) theme for all users, keeps the advanced setting ui hidden. * Keeps the theme switching logic for when the OUI cascadia theme is ready. Resolves opensearch-project#494 Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
tmarkley
force-pushed
the
theme-version
branch
from
90afde5
to
aba71ca
Compare
AMoo-Miki
reviewed
Dec 12, 2022
| }); | ||
|
|
||
| it('should not accept v8 (beta)', () => { | ||
| expect(() => validate('v7')).toThrowErrorMatchingInlineSnapshot(` |
There was a problem hiding this comment.
Suggested change
| expect(() => validate('v7')).toThrowErrorMatchingInlineSnapshot(` | |
| expect(() => validate('v8 (beta)')).toThrowErrorMatchingInlineSnapshot(` |
| }), | ||
| requiresPageReload: true, | ||
| schema: schema.oneOf([schema.literal('v7'), schema.literal('v8 (beta)')]), | ||
| value: 'v1', |
There was a problem hiding this comment.
I believe we are planning on having a beta theme for the 2.x branch. @kgcreative @KrooshalUX please share your thoughts on if we should remove this piece or retain it.
|
#3045 supersedes this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to determine the best way to test this change.
Description
Issues Resolved
Resolves #494
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr