Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional test updates #304

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Apr 21, 2021

Description

More updates related to functional tests that need to be fix for them to pass. Ignoring the map related functional tests for now (link to issue). This does not fix all of the functional tests but there is a remaining ~10 functional tests that are passing.

Issues Resolved

#247

Check List

  • New functionality includes testing.
    • All tests pass (besides some functional)
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Removing references to kibana

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Ignore map related functional tests temporarily until we have a
replacement for EMS.

See: opensearch-project#221

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla added this to the Beta release milestone Apr 21, 2021
@kavilla kavilla changed the title Kavilla/update func test ci group2 more Functional test updates Apr 21, 2021
@kavilla
Copy link
Member Author

kavilla commented Apr 21, 2021

Current failures: #247 (comment)

Please note two failures: #247 (comment)

@odfe-release-bot
Copy link

✅   DCO Check Passed f85af1c

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Thanks @kavilla for all the hard work and making great progress.
Couple of question, the .ndjson file would be great if we can add some documentation around what is significance of it as well as are these somehow auto generated ?.

I see many new files but no deletion, were they deleted as part of previous wipeout ?

@kavilla
Copy link
Member Author

kavilla commented Apr 21, 2021

Couple of question, the .ndjson file would be great if we can add some documentation around what is significance of it as well as are these somehow auto generated ?.

I manually updated the .ndjson files but from my understanding it must have been originally exported while the sample data was originally created. Basically it loads all the saved data for functional tests.

I see many new files but no deletion, were they deleted as part of previous wipeout ?

Some files were deleted due to logos. But I believe most of them (for example the zip files) is just github showing them as 100% modified but it's not good at showing diffs in zip files. But I had to unzip them and replace values in there.

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihirsoni mihirsoni linked an issue Apr 22, 2021 that may be closed by this pull request
2 tasks
@mihirsoni mihirsoni merged commit 1bfa6e4 into opensearch-project:main Apr 22, 2021
@kavilla kavilla deleted the kavilla/update-func-test-ciGroup2-more branch April 27, 2021 19:48
kavilla added a commit that referenced this pull request May 21, 2021
* [Tests] ciGroup2 fully passing

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [Tests] updated ndjson files

Removing references to kibana

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [Tests] ignore map-related functional tests

Ignore map related functional tests temporarily until we have a
replacement for EMS.

See: #221

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [Tests] Update dashboards data to correct config

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [Tests] update ndjson to big to correct type

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Mar 22, 2024
* Add update workspace page

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Fix test failure

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Add more unit test

Signed-off-by: gaobinlong <gbinlong@amazon.com>

---------

Signed-off-by: gaobinlong <gbinlong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tests] Ensure functional test cases pass
5 participants