-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional test updates #304
Functional test updates #304
Conversation
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Removing references to kibana Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Ignore map related functional tests temporarily until we have a replacement for EMS. See: opensearch-project#221 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Current failures: #247 (comment) Please note two failures: #247 (comment) |
✅ DCO Check Passed f85af1c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !! Thanks @kavilla for all the hard work and making great progress.
Couple of question, the .ndjson
file would be great if we can add some documentation around what is significance of it as well as are these somehow auto generated ?.
I see many new files but no deletion, were they deleted as part of previous wipeout ?
I manually updated the
Some files were deleted due to logos. But I believe most of them (for example the zip files) is just github showing them as 100% modified but it's not good at showing diffs in zip files. But I had to unzip them and replace values in there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [Tests] ciGroup2 fully passing Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Tests] updated ndjson files Removing references to kibana Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Tests] ignore map-related functional tests Ignore map related functional tests temporarily until we have a replacement for EMS. See: #221 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Tests] Update dashboards data to correct config Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Tests] update ndjson to big to correct type Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
* Add update workspace page Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix test failure Signed-off-by: gaobinlong <gbinlong@amazon.com> * Add more unit test Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com>
Description
More updates related to functional tests that need to be fix for them to pass. Ignoring the map related functional tests for now (link to issue). This does not fix all of the functional tests but there is a remaining ~10 functional tests that are passing.
Issues Resolved
#247
Check List