Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.4] [MD]Update MD data source documentation link #2800

Merged
merged 1 commit into from
Nov 4, 2022
Merged

[Backport 2.4] [MD]Update MD data source documentation link #2800

merged 1 commit into from
Nov 4, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 1ecfee7 from #2693.

@github-actions
[MD]Update MD data source documentation link (#2693)
981870b 
Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
(cherry picked from commit 1ecfee7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner November 4, 2022 20:11
zhongnansu
zhongnansu reviewed Nov 4, 2022
View reviewed changes
Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing change log?

@ananzh
Copy link
Member

ananzh commented Nov 4, 2022

missing change log?

yeah CHANGLOG is blocking auto-backport. currently we just ignore changelog. we will change that after release.

@codecov-commenter
Copy link

Codecov Report

Merging #2800 (981870b) into 2.4 (c44be8b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.4    #2800      +/-   ##
==========================================
- Coverage   66.67%   66.67%   -0.01%     
==========================================
  Files        3219     3219              
  Lines       61445    61445              
  Branches     9417     9417              
==========================================
- Hits        40970    40966       -4     
- Misses      18229    18232       +3     
- Partials     2246     2247       +1
Impacted Files Coverage Δ
src/core/public/doc_links/doc_links_service.ts 100.00% <ø> (ø)
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 83.67% <0.00%> (-4.09%) ⬇️
packages/osd-optimizer/src/node/cache.ts 50.00% <0.00%> (-2.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ananzh ananzh merged commit d2fce39 into 2.4 Nov 4, 2022
@github-actions github-actions bot deleted the backport/backport-2693-to-2.4 branch November 4, 2022 21:50
@joshuarrrr joshuarrrr added the v2.4.0 'Issues and PRs related to version v2.4.0' label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongnansu zhongnansu zhongnansu approved these changes

@ananzh ananzh ananzh approved these changes

Assignees
No one assigned
Labels
v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ananzh @codecov-commenter @zhongnansu @joshuarrrr