Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [MD] Make text content dynamically translated & update unit tests #2571

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9a55e0c from #2570

)

* Make text content dynamically translated
* add unit tests

Signed-off-by: Yibo Wang <yibow@amazon.com>
(cherry picked from commit 9a55e0c)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner October 13, 2022 21:37
@codecov-commenter
Copy link

Codecov Report

Merging #2571 (a4242e7) into 2.x (7c1475f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              2.x    #2571      +/-   ##
==========================================
- Coverage   66.71%   66.71%   -0.01%     
==========================================
  Files        3204     3202       -2     
  Lines       60964    60906      -58     
  Branches     9267     9267              
==========================================
- Hits        40671    40631      -40     
+ Misses      18074    18058      -16     
+ Partials     2219     2217       -2     
Impacted Files Coverage Δ
.../public/components/create_button/create_button.tsx 100.00% <ø> (ø)
...ents/experimental_callout/experimental_callout.tsx 50.00% <ø> (-50.00%) ⬇️
...components/create_form/create_data_source_form.tsx 98.36% <100.00%> (+14.75%) ⬆️
...te_data_source_wizard/components/header/header.tsx 100.00% <100.00%> (ø)
...components/data_source_table/data_source_table.tsx 100.00% <100.00%> (+3.17%) ⬆️
...omponents/validation/datasource_form_validation.ts 100.00% <100.00%> (ø)
...nent/experimental_callout/experimental_callout.tsx
...ic/application/models/sense_editor/sense_editor.ts 64.88% <0.00%> (+0.88%) ⬆️
packages/osd-optimizer/src/node/cache.ts 52.77% <0.00%> (+2.77%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kavilla kavilla merged commit b37e7dd into 2.x Oct 17, 2022
@github-actions github-actions bot deleted the backport/backport-2570-to-2.x branch October 17, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants