[Rename] Renames elastic-safer-lodash-set dependency #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ DCO Check Passed 17ab2b6 |
Renames the elastic-safer-lodash-set to opensearch-safer-lodash-set and updated precommit hook rules and eslintignore since this package file names need to match upstream lodash Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
boktorbb
changed the title
|
✅ DCO Check Passed bf269d7 |
mihirsoni
approved these changes
Apr 7, 2021
|
Still references to the old package name in the README, did we want to update those? Also did we want to update the package.json values? I am unable to build this PR. Should I be pulling down all the PRs for building? |
kavilla
reviewed
Apr 7, 2021
Yes, can you pull all 3 PRs down |
I was directed to only rename the top level dir and nothing else |
|
we are told to keep things mostly the same, so after cherry-picking all the commits, everything resolved so my comments can be resolved. |
kavilla
approved these changes
Apr 7, 2021
boktorbb
added a commit
that referenced
this pull request
Apr 8, 2021
Renames the elastic-safer-lodash-set to opensearch-safer-lodash-set and updated precommit hook rules and eslintignore since this package file names need to match upstream lodash Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
wanglam
added a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Feb 27, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Feb 28, 2024
…opensearch-project#253) (cherry picked from commit 734c890) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Mar 7, 2024
…n management and SavedObject management as standalone app, retire dashboard management (opensearch-project#283) * Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (opensearch-project#208)" This reverts commit 5f09f84. * Revert "feat: add unit test for mountWrapper (opensearch-project#223)" This reverts commit a70ce71. * Revert "fix: cypress tests checkout workspace branch (opensearch-project#252)" This reverts commit 734c890. * run cypress with ftr main Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 18, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 18, 2024
…n management and SavedObject management as standalone app, retire dashboard management (opensearch-project#283) * Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (opensearch-project#208)" This reverts commit 5f09f84. * Revert "feat: add unit test for mountWrapper (opensearch-project#223)" This reverts commit a70ce71. * Revert "fix: cypress tests checkout workspace branch (opensearch-project#252)" This reverts commit 734c890. * run cypress with ftr main Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames elastic-safer-lodash-set --> opensearch-safer-lodash-set
Check List