Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with instructions for running with OpenSearch #235

Merged
merged 3 commits into from
Mar 26, 2021
Merged

Update README with instructions for running with OpenSearch #235

merged 3 commits into from
Mar 26, 2021

Conversation

boktorbb
Copy link
Contributor

updated README with download and setup instructions for both OpenSearch
and Dashboards.

Closes #223

Signed-off-by: Bishoy Boktor boktorbb@amazon.com

updated README with download and setup instructions for both OpenSearch
and Dashboards.

Closes #223

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@boktorbb boktorbb added the docs Improvements or additions to documentation label Mar 26, 2021
@boktorbb boktorbb added this to the Beta release milestone Mar 26, 2021
@odfe-release-bot
Copy link

✅   DCO Check Passed f09fab8

kavilla
kavilla previously approved these changes Mar 26, 2021
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one NIT and question.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@odfe-release-bot
Copy link

✅   DCO Check Passed da55dfd

kavilla
kavilla previously approved these changes Mar 26, 2021
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

seanneumann
seanneumann previously approved these changes Mar 26, 2021
Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


To run OpenSearch Dashboards locally, you first need build artifacts from OpenSearch.
* Clone the OpenSearch Repo [here](https://github.com/opensearch-project/OpenSearch.git)
* Follow installation and setup instructions in the OpenSearch repo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just add git clone <> command here so users may not have to jump the page ???

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@boktorbb boktorbb dismissed stale reviews from seanneumann and kavilla via 4f4bb30 March 26, 2021 22:14
@odfe-release-bot
Copy link

✅   DCO Check Passed 4f4bb30

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@mihirsoni mihirsoni merged commit dde8ced into opensearch-project:main Mar 26, 2021
kavilla pushed a commit that referenced this pull request Apr 5, 2021
* Update README with instructions for running with OpenSearch

updated README with download and setup instructions for both OpenSearch
and Dashboards.

Closes #223

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>

* Address PR comments

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>

* Address PR comments

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 23, 2023
…pensearch-project#235)

* feature: cannot delete last admin user/group in workspace settings

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor code with useMemo

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build] OpenSearch Dashboards working using OpenSearch Engine
5 participants