Commits on Sep 8, 2022

1. [BUG] fix healthcheck logic to expect object and return ids (#2277) (#… …

   …2300)
   
   Original implementation incorrectly assumed the return list of
   nodes was an object array.
   This PR:
   #2232
   
   Addressed the return but didn't catch the nodes.find in the return
   which is a function for an array.
   
   Also, refactors to return a list of node_ids because the original
   implementation indicated that it should but it can return node ids
   but it never did. It only returned `null` or `_local`, the problem
   with this approach is that it doesn't expect valid node version
   with different DIs or filter out nodes when we pass `null` as the node
   ID for the node info call because it was fan out the request to all
   nodes.
   
   Now this function will return `_local` if all the nodes share the
   same cluster_id using a greedy approach since we can assume it is
   all the same version.
   
   Will return node ids, if the cluster_id are different so it will
   pass a CSV to the node info call and return the info for those nodes.
   And null if no cluster_id is present, ie, fan out the response.
   
   Original issue:
   #2203
   
   Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
   
   Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
   (cherry picked from commit e10ba34)

   

   kavilla authored and github-actions[bot] committed Sep 8, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for c2576af
   • Browse repository at this point

   Copy the full SHA

   c2576af View commit details

   Browse the repository at this point in the history