Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Adding Github Issue / PR templates #206

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

mihirsoni
Copy link
Contributor

Signed-off-by: Mihir Soni mihirsoni.123@gmail.com

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
boktorbb
boktorbb previously approved these changes Mar 22, 2021
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but otherwise looks good

kavilla
kavilla previously approved these changes Mar 22, 2021
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments but perhaps they were on purpose.

.github/ISSUE_TEMPLATE/bug_template.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_template.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_template.md Show resolved Hide resolved
seanneumann
seanneumann previously approved these changes Mar 22, 2021
Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to other comments. Otherwise LGTM.

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
@mihirsoni mihirsoni dismissed stale reviews from seanneumann, kavilla, and boktorbb via fb4cbee March 22, 2021 02:13
@odfe-release-bot
Copy link

✅   DCO Check Passed

1 similar comment
@odfe-release-bot
Copy link

✅   DCO Check Passed

@mihirsoni mihirsoni merged commit 6b90a62 into opensearch-project:main Mar 22, 2021
raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Oct 9, 2023
…search-project#206)

* fix: logic passed after validate failed

Signed-off-by: Lin Wang <wonglam@amazon.com>

* test: add integration tests for workspace saved objects client wrapper

Signed-off-by: Lin Wang <wonglam@amazon.com>

* test: remove timeout

Signed-off-by: Lin Wang <wonglam@amazon.com>

* test: refactor with fixed scoped client and ignore delete error in clear all

Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: workspaces can't be query

Signed-off-by: Lin Wang <wonglam@amazon.com>

* update to latest license header

Signed-off-by: Lin Wang <wonglam@amazon.com>

* remove skip migrate and remove keyword suffix

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants