Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Contributing doc #196

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

seanneumann
Copy link
Contributor

Signed-off-by: Neumann neumanns@amazon.com

Signed-off-by: Neumann <neumanns@amazon.com>
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!!

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@odfe-release-bot
Copy link

✅   DCO Check Passed

@mihirsoni mihirsoni merged commit c268ccb into opensearch-project:dashboards Mar 19, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
Signed-off-by: Neumann <neumanns@amazon.com>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Neumann <neumanns@amazon.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Neumann <neumanns@amazon.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Oct 9, 2023
…ch-project#196)

* Patch/first pr (opensearch-project#194)

* temp: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add function test for workspace CRUD routes

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use saved objects client instead of internal repository

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update CHANGELOG

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: exclude permission check wrapper

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add integration test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add configuration

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: enable workspace flag when run workspace related test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: change to equal 3

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: make permissions field optional

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: make permissions as optional params

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: make permissions params optional

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants