-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Contributing doc #196
Merged
mihirsoni
merged 1 commit into
opensearch-project:dashboards
from
seanneumann:update-contrib
Mar 19, 2021
Merged
Updated Contributing doc #196
mihirsoni
merged 1 commit into
opensearch-project:dashboards
from
seanneumann:update-contrib
Mar 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neumann <neumanns@amazon.com>
mihirsoni
approved these changes
Mar 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!!
boktorbb
approved these changes
Mar 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
✅ DCO Check Passed |
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
Signed-off-by: Neumann <neumanns@amazon.com>
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
Signed-off-by: Neumann <neumanns@amazon.com>
mihirsoni
pushed a commit
that referenced
this pull request
Mar 20, 2021
Signed-off-by: Neumann <neumanns@amazon.com>
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Oct 9, 2023
…ch-project#196) * Patch/first pr (opensearch-project#194) * temp: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add function test for workspace CRUD routes Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use saved objects client instead of internal repository Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update CHANGELOG Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: exclude permission check wrapper Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add integration test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add configuration Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: enable workspace flag when run workspace related test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change to equal 3 Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make permissions field optional Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: make permissions as optional params Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: make permissions params optional Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neumann neumanns@amazon.com