-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating root readme. #195
Updating root readme. #195
Conversation
Signed-off-by: Neumann <neumanns@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
✅ DCO Check Passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you touch on the idea that the code currently will have bugs and issues somewhere and that it shouldn't be expected that it works perfectly? Maybe as a bullet point under the What doesn't work
heading? Otherwise, looks good
README.md
Outdated
* Integration test cases | ||
* Functional test cases | ||
* 3rd party plugins (including OpenDistro) | ||
* Works with OpenSearch engine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this implying it doesn't work with ElasticSearch engine?
README.md
Outdated
* All references to non-Apache 2.0 code should be removed. | ||
* Core plugins (non-3rd party) | ||
* New project name should be used everywhere. | ||
* yarn osd bootstrap, EsLint and commit hook should be passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EsLint
nit: but should probably be ESLint
README.md
Outdated
Please check to make sure someone else hasn't already created an issue for the same topic. | ||
- Need help using OpenSearch Dashboards? Ask away on our [OpenSearch Dashboards Discuss Forum](https://discuss.elastic.co/c/kibana) and a fellow community member or | ||
OpenSearch Dashboards engineer will be glad to help you out. | ||
Let us know in the forums. w00t!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a link to the forums?
|
||
If you want to use a OpenSearch Dashboards release in production, give it a test run, or just play around: | ||
## What doesn’t works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: What doesn't work
Signed-off-by: Neumann <neumanns@amazon.com>
* Updating root readme. Signed-off-by: Neumann <neumanns@amazon.com> * Addressed PR comments Signed-off-by: Neumann <neumanns@amazon.com>
* Updating root readme. Signed-off-by: Neumann <neumanns@amazon.com> * Addressed PR comments Signed-off-by: Neumann <neumanns@amazon.com>
* Updating root readme. Signed-off-by: Neumann <neumanns@amazon.com> * Addressed PR comments Signed-off-by: Neumann <neumanns@amazon.com>
…project#195) * feat: remove management permission mode and clearify library permission mode usage Signed-off-by: Lin Wang <wonglam@amazon.com> * address PR comments and add annotations Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>
…project#195) * feat: remove management permission mode and clearify library permission mode usage Signed-off-by: Lin Wang <wonglam@amazon.com> * address PR comments and add annotations Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Neumann neumanns@amazon.com