Updating root readme. #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neumann <neumanns@amazon.com>
|
✅ DCO Check Passed |
boktorbb
reviewed
Mar 19, 2021
kavilla
approved these changes
Mar 19, 2021
README.md
Outdated
| * Integration test cases | ||
| * Functional test cases | ||
| * 3rd party plugins (including OpenDistro) | ||
| * Works with OpenSearch engine |
There was a problem hiding this comment.
Is this implying it doesn't work with ElasticSearch engine?
README.md
Outdated
| * All references to non-Apache 2.0 code should be removed. | ||
| * Core plugins (non-3rd party) | ||
| * New project name should be used everywhere. | ||
| * yarn osd bootstrap, EsLint and commit hook should be passing. |
There was a problem hiding this comment.
EsLint
nit: but should probably be ESLint
README.md
Outdated
| Please check to make sure someone else hasn't already created an issue for the same topic. | ||
| - Need help using OpenSearch Dashboards? Ask away on our [OpenSearch Dashboards Discuss Forum](https://discuss.elastic.co/c/kibana) and a fellow community member or | ||
| OpenSearch Dashboards engineer will be glad to help you out. | ||
| Let us know in the forums. w00t!!! |
boktorbb
approved these changes
Mar 19, 2021
boktorbb
reviewed
Mar 19, 2021
|
|
||
| If you want to use a OpenSearch Dashboards release in production, give it a test run, or just play around: | ||
| ## What doesn’t works |
Signed-off-by: Neumann <neumanns@amazon.com>
Closed
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
* Updating root readme. Signed-off-by: Neumann <neumanns@amazon.com> * Addressed PR comments Signed-off-by: Neumann <neumanns@amazon.com>
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
* Updating root readme. Signed-off-by: Neumann <neumanns@amazon.com> * Addressed PR comments Signed-off-by: Neumann <neumanns@amazon.com>
mihirsoni
pushed a commit
that referenced
this pull request
Mar 20, 2021
* Updating root readme. Signed-off-by: Neumann <neumanns@amazon.com> * Addressed PR comments Signed-off-by: Neumann <neumanns@amazon.com>
wanglam
added a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Sep 26, 2023
…project#195) * feat: remove management permission mode and clearify library permission mode usage Signed-off-by: Lin Wang <wonglam@amazon.com> * address PR comments and add annotations Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Oct 9, 2023
…project#195) * feat: remove management permission mode and clearify library permission mode usage Signed-off-by: Lin Wang <wonglam@amazon.com> * address PR comments and add annotations Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neumann neumanns@amazon.com