[Backport 2.x] [UX] Consolidate menu bars #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Add a config option to remove the upper global header and incorporate all items into a single header. While the previous expanded dual header is still the default, we've added a new home button which also serves as the location of the global loading indicator. Additional changes: * update branding unit tests * fix header spacing at smallest breakpoint * update branding functional tests Issue resolved: #1583 Squashed commits: - update branding mark unit tests - fix header spacing at smallest breakpoint - update custom branding functional test - update line chart functional test ticks to account for more ticks visisble with larger height of viz area - update release notes - add branding config for expanded menu - revert release note addition - remove home link from collapsible nav - Add expanded header option - Move navControlsRight to left of help - Rename HeaderLogo to HomeLoader - Serves as unified home button and global loading indicator - Add title for tooltip, because purpose may not be obvious - Rename Mark to HomeIcon - Uses home icon when header expanded by default - Restore HeaderLogo for expanded header - Duplicate default logo, rename to match mark naming (default, dark) - Add new nav control areas for expanded menu only - navControlsExpandedRight - navControlsExpandedCenter - Add new body class for expanded header - used by styles to correctly set app height - remove unecessary duplicate header mixin inclusion - fix functional tests - update test subjects - convert home tests to ts - update names and methods to be more clear - update snapshots - add, update, improve unit tests - keep expanded as default config - restore logo link - update functional tests - group dark mode branding tests - final review updates Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit ae6cb80)
Codecov Report
@@ Coverage Diff @@
## 2.x #1795 +/- ##
======================================
Coverage ? 67.50%
======================================
Files ? 3074
Lines ? 59127
Branches ? 8988
======================================
Hits ? 39911
Misses ? 17031
Partials ? 2185 Continue to review full report at Codecov.
|
kavilla
approved these changes
Jun 24, 2022
seraphjiang
approved these changes
Jun 24, 2022
|
Current run passed for PR and I just triggered the push again. Meaning the CI already passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ae6cb80 from #1586