[Deprecation] Deprecate master nodes and replace with cluster_manager nodes #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1761 +/- ##
=======================================
Coverage 67.51% 67.51%
=======================================
Files 3073 3073
Lines 59069 59069
Branches 8963 8963
=======================================
Hits 39881 39881
Misses 17005 17005
Partials 2183 2183
Continue to review full report at Codecov.
|
ananzh
reviewed
Jun 18, 2022
| @@ -28,7 +28,7 @@ | |||
| "metrics": [ | |||
| "_all", | |||
| "blocks", | |||
| "master_node", | |||
| "cluster_manager_node", | |||
There was a problem hiding this comment.
I think cluster state metrics still have master_node, just deprecated. It will be removed at 3.0. Do we want to keep both to match OpenSearch?
joshuarrrr
previously approved these changes
Jun 21, 2022
|
If you want to rebase then BWC should work again @manasvinibs |
… nodes As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories Issue - opensearch-project#1688 Signed-off-by: manasvinibs <manasvis@amazon.com>
joshuarrrr
approved these changes
Jun 22, 2022
kavilla
approved these changes
Jun 22, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
… nodes (#1761) As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories Issue - #1688 Signed-off-by: manasvinibs <manasvis@amazon.com> (cherry picked from commit 6aba08a)
kavilla
pushed a commit
that referenced
this pull request
Jun 23, 2022
… nodes (#1761) As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories Issue - #1688 Signed-off-by: manasvinibs <manasvis@amazon.com> (cherry picked from commit 6aba08a) Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
joshuarrrr
pushed a commit
that referenced
this pull request
Jun 23, 2022
… nodes (#1761) (#1779) As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories Issue - #1688 Signed-off-by: manasvinibs <manasvis@amazon.com> (cherry picked from commit 6aba08a) Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> Co-authored-by: Manasvini B Suryanarayana <manasvis@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: manasvinibs manasvis@amazon.com
Description
As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories.
In this change we are replacing the instance of 'master' node with 'cluster_manager'.
Issues Resolved
#1688
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr