Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] visualize plugin #160

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 10, 2021

Issue #, if available:
#37

Description of changes:
Rename files and variables with plugins/visualize

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/plugins/visualize/public/plugin.ts Outdated Show resolved Hide resolved
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boktorbb boktorbb merged commit 5374bee into opensearch-project:dashboards Mar 12, 2021
@kavilla kavilla deleted the visualize branch March 18, 2021 08:01
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
* [Rename] visualize plugin

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Address PR comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this pull request Mar 20, 2021
* [Rename] visualize plugin

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Address PR comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
* [Rename] visualize plugin

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Address PR comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
…me validation (opensearch-project#156) (opensearch-project#160)

(cherry picked from commit f350eb3)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants