Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] Refactored src/legacy directory #142

Merged
merged 2 commits into from
Mar 11, 2021
Merged

[Rename] Refactored src/legacy directory #142

merged 2 commits into from
Mar 11, 2021

Conversation

mihirsoni
Copy link
Contributor

Issue #, if available: #37

Description of changes: Refactored src/legacy directory

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a variable change from constants file other lgtm!

@@ -17,7 +17,7 @@
* under the License.
*/

import { i18nLoader } from '@kbn/i18n';
import { i18nLoader } from '@osd/i18n';
import { size } from 'lodash';
import { UsageCollectionSetup } from 'src/plugins/usage_collection/server';
import { getIntegrityHashes, Integrities } from './file_integrity';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 24 KIBANA_LOCALIZATION_STATS_TYPE

@kavilla
Copy link
Member

kavilla commented Mar 11, 2021

LGTM

@kavilla kavilla self-requested a review March 11, 2021 03:17
@kavilla kavilla merged commit d563d75 into opensearch-project:dashboards Mar 11, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
* [Rename] Refactored src/legacy directory

* [Rename] addressed review feedbacks

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
* [Rename] Refactored src/legacy directory

* [Rename] addressed review feedbacks

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
mihirsoni added a commit that referenced this pull request Mar 20, 2021
* [Rename] Refactored src/legacy directory

* [Rename] addressed review feedbacks

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 13, 2023
…ds declaration in repositoryClient (opensearch-project#142)

* refractor: remove additional method declaration

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: make bootstrap run

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: change to single permission modes

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: rename variable

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
…ds declaration in repositoryClient (opensearch-project#142)

* refractor: remove additional method declaration

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: make bootstrap run

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: change to single permission modes

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: rename variable

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 05fab00)
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
…ds declaration in repositoryClient (opensearch-project#142) (opensearch-project#157)

* refractor: remove additional method declaration

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: make bootstrap run

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: change to single permission modes

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: rename variable

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 05fab00)
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
…ds declaration in repositoryClient (opensearch-project#142)

* refractor: remove additional method declaration

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: make bootstrap run

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: change to single permission modes

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: rename variable

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants