Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rename] Refactored src/{typings,test_helpers,utils} root files #140

Merged
merged 6 commits into from
Mar 12, 2021
Merged

[Rename] Refactored src/{typings,test_helpers,utils} root files #140

merged 6 commits into from
Mar 12, 2021

Conversation

mihirsoni
Copy link
Contributor

Issue #, if available: #37

Description of changes: [Rename] Refactored src/{typings,test_helpers,utils} root files

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

boktorbb
boktorbb suggested changes Mar 10, 2021
View reviewed changes
src/core/CONVENTIONS.md Outdated Show resolved Hide resolved
src/core/CONVENTIONS.md Outdated Show resolved Hide resolved
src/core/test_helpers/osd_server.ts Outdated Show resolved Hide resolved
@mihirsoni mihirsoni requested a review from boktorbb March 10, 2021 23:56
kavilla
kavilla reviewed Mar 11, 2021
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super small comment

src/core/test_helpers/osd_server.ts Outdated Show resolved Hide resolved
boktorbb
boktorbb approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kavilla kavilla self-requested a review March 12, 2021 03:41
kavilla
kavilla approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kavilla kavilla merged commit 52f55fe into opensearch-project:dashboards Mar 12, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
@mihirsoni @kavilla
[Rename] Refactored src/{typings,test_helpers,utils} root files (#140)
92540a1 
* [Rename] src/core/test_helpers

* [Rename] src/core/types

* [Rename] src/core/utils

* [Rename] src/core/ docs

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
@mihirsoni @kavilla
[Rename] Refactored src/{typings,test_helpers,utils} root files (#140)
19d40b8 
* [Rename] src/core/test_helpers

* [Rename] src/core/types

* [Rename] src/core/utils

* [Rename] src/core/ docs

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
mihirsoni added a commit that referenced this pull request Mar 20, 2021
@mihirsoni
[Rename] Refactored src/{typings,test_helpers,utils} root files (#140)
d03910d 
* [Rename] src/core/test_helpers

* [Rename] src/core/types

* [Rename] src/core/utils

* [Rename] src/core/ docs

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
@SuZhou-Joe
Self host runner (opensearch-project#140)
6ed68c9 
* feat: add self host runner

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use v4

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Revert "feat: use v4"

This reverts commit fc24867.

* feat: use auto-scaleable runners

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use sudo

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
@SuZhou-Joe
Self host runner (opensearch-project#140)
878f831 
* feat: add self host runner

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use v4

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Revert "feat: use v4"

This reverts commit fc24867.

* feat: use auto-scaleable runners

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use sudo

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
@SuZhou-Joe
Self host runner (opensearch-project#140) (opensearch-project#155)
2f2aa2b 
* feat: add self host runner



* feat: update



* feat: update

* feat: update



* feat: use v4



* feat: update



* Revert "feat: use v4"

This reverts commit fc24867.

* feat: use auto-scaleable runners



* feat: use sudo



* feat: update



---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
@SuZhou-Joe @ruanyl
Self host runner (opensearch-project#140)
db5b60a 
* feat: add self host runner

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use v4

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Revert "feat: use v4"

This reverts commit fc24867.

* feat: use auto-scaleable runners

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use sudo

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 2, 2024
@SuZhou-Joe
Self host runner (opensearch-project#140)
89b600a 
* feat: add self host runner

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use v4

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Revert "feat: use v4"

This reverts commit fc24867.

* feat: use auto-scaleable runners

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use sudo

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 2, 2024
@SuZhou-Joe
Self host runner (opensearch-project#140)
339752d 
* feat: add self host runner

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use v4

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Revert "feat: use v4"

This reverts commit fc24867.

* feat: use auto-scaleable runners

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use sudo

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 2, 2024
@SuZhou-Joe
Self host runner (opensearch-project#140)
978af7d 
* feat: add self host runner

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use v4

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Revert "feat: use v4"

This reverts commit fc24867.

* feat: use auto-scaleable runners

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use sudo

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 3, 2024
@SuZhou-Joe
Self host runner (opensearch-project#140)
cdd660e 
* feat: add self host runner

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use v4

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Revert "feat: use v4"

This reverts commit fc24867.

* feat: use auto-scaleable runners

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use sudo

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@boktorbb boktorbb boktorbb approved these changes

Assignees
No one assigned
Labels
rename
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihirsoni @kavilla @boktorbb