Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] Refactored test/* director #137

Merged
merged 5 commits into from
Mar 12, 2021
Merged

[Rename] Refactored test/* director #137

merged 5 commits into from
Mar 12, 2021

Conversation

mihirsoni
Copy link
Contributor

Issue #, if available: #37

Description of changes: [Rename] Refactored test/* directory

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

./test/scripts/jenkins_build_plugins.sh
fi

# doesn't persist, also set in OpenSearchDashboardsPipeline.groovy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibanaPipeline.groovy --->opensearchDashboardsPipeline.groovy
shouldn't use capital OpenSearch

Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Mihir, I wrote several comments and asked all the unsure stuff. Should be okay

@@ -36,7 +36,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
require.resolve('./apps/console'),
require.resolve('./apps/home'),
require.resolve('./apps/filter_panel'),
require.resolve('./apps/kibana_overview'),
require.resolve('./apps/opensearch_dashboardsoverview'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing an '_'

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boktorbb boktorbb merged commit 62ce8f8 into opensearch-project:dashboards Mar 12, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
* [Rename] Refactored test/* directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] Renamed directories and files

* [Rename] addressed review feedbacks

* [Rename] addressed review feedbacks

* [Rename] addressed review feedbacks
kavilla pushed a commit that referenced this pull request Mar 20, 2021
* [Rename] Refactored test/* directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] Renamed directories and files

* [Rename] addressed review feedbacks

* [Rename] addressed review feedbacks

* [Rename] addressed review feedbacks
mihirsoni added a commit that referenced this pull request Mar 20, 2021
* [Rename] Refactored test/* directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] Renamed directories and files

* [Rename] addressed review feedbacks

* [Rename] addressed review feedbacks

* [Rename] addressed review feedbacks
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
…t#137)

* hide import for application home page



* add workpspace into gotoApp link



* remove special logic for management workspace



* variable name change and more UTs



---------


(cherry picked from commit afa373a)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants