-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] Refactored test/* director #137
Conversation
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
test/functional/fixtures/es_archiver/dashboard/current/opensearch_dashboards/mappings.json
Outdated
Show resolved
Hide resolved
./test/scripts/jenkins_build_plugins.sh | ||
fi | ||
|
||
# doesn't persist, also set in OpenSearchDashboardsPipeline.groovy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibanaPipeline.groovy --->opensearchDashboardsPipeline.groovy
shouldn't use capital OpenSearch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Mihir, I wrote several comments and asked all the unsure stuff. Should be okay
test/accessibility/config.ts
Outdated
@@ -36,7 +36,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) { | |||
require.resolve('./apps/console'), | |||
require.resolve('./apps/home'), | |||
require.resolve('./apps/filter_panel'), | |||
require.resolve('./apps/kibana_overview'), | |||
require.resolve('./apps/opensearch_dashboardsoverview'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing an '_'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [Rename] Refactored test/* directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Renamed directories and files * [Rename] addressed review feedbacks * [Rename] addressed review feedbacks * [Rename] addressed review feedbacks
* [Rename] Refactored test/* directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Renamed directories and files * [Rename] addressed review feedbacks * [Rename] addressed review feedbacks * [Rename] addressed review feedbacks
* [Rename] Refactored test/* directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Renamed directories and files * [Rename] addressed review feedbacks * [Rename] addressed review feedbacks * [Rename] addressed review feedbacks
…t#137) * hide import for application home page * add workpspace into gotoApp link * remove special logic for management workspace * variable name change and more UTs --------- (cherry picked from commit afa373a) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Issue #, if available: #37
Description of changes: [Rename] Refactored test/* directory
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.