[Map] Remove hardcoded AWS paths #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavilla
reviewed
Dec 13, 2021
There was a problem hiding this comment.
Looks good to me. The config name can probably be discussed to ensure everyone is happy with it.
Also, I apologize it's my fault since I implemented this without tests but we also made a change to use OpenSearch Maps without testing this logic as well. Would you be willing to get a little bit of tests in here with this new flag?
tmarkley
reviewed
Dec 17, 2021
zuochengding
force-pushed
the
hardcode-aws-path
branch
from
0c1f4ca to
9eb4d44
Compare
tmarkley
previously approved these changes
Dec 28, 2021
|
Do we need to rebase to fix the linkchecker issue? |
Clean up temp aws paths in code base. Add a configurable flag `showRegionBlockedWarning` into map plugin level config file. Signed-off-by: Zuocheng Ding <zding817@gmail.com>
zuochengding
force-pushed
the
hardcode-aws-path
branch
from
9eb4d44 to
79dfd64
Compare
kavilla
approved these changes
Jan 6, 2022
kavilla
pushed a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Jan 10, 2022
Clean up temp aws paths in code base. Add a configurable flag `showRegionBlockedWarning` into map plugin level config file. Backport PR: opensearch-project#1015 Signed-off-by: Zuocheng Ding <zding817@gmail.com>
7 tasks
kavilla
pushed a commit
that referenced
this pull request
Jan 13, 2022
Clean up temp aws paths in code base. Add a configurable flag `showRegionBlockedWarning` into map plugin level config file. Backport PR: #1015 Signed-off-by: Zuocheng Ding <zding817@gmail.com>
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up temp aws paths in code base.
Add a configurable flag
captureRegionBlockedErrorinto map plugin level config file.Signed-off-by: Zuocheng Ding zding817@gmail.com
Description
Clean up temp aws paths in code base.
Add a configurable flag
captureRegionBlockedErrorinto map plugin level config file.Customer should able to modify the config in
opensearch_dashboards.ymlif they want.Issues Resolved
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr