Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] handle version in docs #892

Closed
kavilla opened this issue Oct 27, 2021 · 0 comments · Fixed by #905
Closed

[Docs] handle version in docs #892

kavilla opened this issue Oct 27, 2021 · 0 comments · Fixed by #905
Labels
docs Improvements or additions to documentation enhancement New feature or request v1.3.0

Comments

@kavilla
Copy link
Member

kavilla commented Oct 27, 2021

Is your feature request related to a problem? Please describe.

The docs site is versioned based on off major and minor version, for example: https://opensearch.org/docs/1.0/dashboards/index/.

Describe the solution you'd like

This service: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/core/public/doc_links/doc_links_service.ts will have to be updated to take the branch version (or if main latest) then route the right page. We also need to start making sure to update https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/package.json#L15 to be the correct version so if on the 1.2 branch then this line should read 1.2

Describe alternatives you've considered

n/a

Additional context

Blocking: #769

@kavilla kavilla added enhancement New feature or request docs Improvements or additions to documentation labels Oct 27, 2021
@zuochengding zuochengding linked a pull request Nov 5, 2021 that will close this issue
5 tasks
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation enhancement New feature or request v1.3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants