Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] User cannot save a filter for ip field with CIDR notation value #306

Closed
micrictor opened this issue Apr 21, 2021 · 0 comments · Fixed by #300
Closed

[BUG] User cannot save a filter for ip field with CIDR notation value #306

micrictor opened this issue Apr 21, 2021 · 0 comments · Fixed by #300
Labels
bug Something isn't working

Comments

@micrictor
Copy link
Contributor

Describe the bug

Users of OpenSearch dashboards can not specify a CIDR mask value when creating a filter against a field of type ip. This syntax will work in the underlying search DSL, and users can manually input a CIDR mask by directly editing the DSL.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Discover page
  2. Attempt to create a new filter on an IP field, using is or is one of as the selector
  3. Input a CIDR mask as the filter value
  4. The "Save" button remains inactive
    Expected behavior
    The filter UI should recognize CIDR masks as valid inputs for IP fields.

OpenSearch Version
N/A

Dashboards Version
1.0.0

Additional context

This was first reported in Kibana 7.5 - elastic/kibana#50520
@micrictor micrictor added the bug Something isn't working label Apr 21, 2021
@micrictor micrictor mentioned this issue Apr 21, 2021
Merged
3 tasks
@mihirsoni mihirsoni linked a pull request Apr 22, 2021 that will close this issue
Add support for CIDR mask filters on IP fields #300
Merged
3 tasks
mihirsoni pushed a commit that referenced this issue Apr 22, 2021
@micrictor
[BUG] Add support for CIDR mask filters on IP fields (#300)
7ad2b1b 
Signed-off-by: Michael Torres <mic.ric.tor@gmail.com>

Fixes #306
kavilla pushed a commit that referenced this issue May 21, 2021
@micrictor @kavilla
[BUG] Add support for CIDR mask filters on IP fields (#300)
62a3115 
Signed-off-by: Michael Torres <mic.ric.tor@gmail.com>

Fixes #306
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this issue Apr 16, 2024
@Hailong-am
Add enabledOperators parameter for workspace name unique check (opens…
da95876 
…earch-project#306)

* Add enabledOperators parameter for workspace name unique check

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add test for enabled opeartors

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add integration test

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this issue Apr 19, 2024
@Hailong-am @raintygao
Add enabledOperators parameter for workspace name unique check (opens…
7fe5127 
…earch-project#306)

* Add enabledOperators parameter for workspace name unique check

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add test for enabled opeartors

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Add integration test

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for CIDR mask filters on IP fields
1 participant
@micrictor