Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for build version qualifiers. #1340

Closed
dblock opened this issue Mar 11, 2022 · 1 comment
Closed

Add support for build version qualifiers. #1340

dblock opened this issue Mar 11, 2022 · 1 comment
Labels
enhancement New feature or request v2.0.0

Comments

@dblock
Copy link
Member

dblock commented Mar 11, 2022

Coming from opensearch-project/opensearch-build#1632, add support for -Dbuild.version_qualifier=.

The distribution build process now supports passing additional optional qualifiers other than the 3 digit versions, e.g. 2.0.0-alpha1. Add the ability to pass additional qualifier to build scripts, and generate artifacts with a version that includes the qualifier.

@dblock dblock added the enhancement New feature or request label Mar 11, 2022
@dblock dblock added the v2.0.0 label Mar 22, 2022
kavilla added a commit to kavilla/opensearch-build that referenced this issue Mar 27, 2022
Support version qualifier builds for OpenSearch Dashboards and
OpenSearch Dashboards Plugins.

This will create a zip for plugins with the OpenSearch Dashboards
version + qualifier. But the version of the plugin will remain the
same whilst opensearchDashboardsVersion in the opensearch_dashboards.json
will be the OpenSearch Dashboards version, eg, 1.3.0-alpha1. This is why
the version check needed to be modified a little to ensure that it can
get the version + qualifier and the default version of the plugin.

Updated for plugins as well.

Was able to successfully build and connect OSD 1.3.0-alpha1 to
the release version of OS 1.3.0.

Issue resolved:
opensearch-project/OpenSearch-Dashboards#1340

Issue partially resolved:
opensearch-project#1632

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/opensearch-build that referenced this issue Mar 29, 2022
Support version qualifier builds for OpenSearch Dashboards and
OpenSearch Dashboards Plugins.

This will create a zip for plugins with the OpenSearch Dashboards
version + qualifier. But the version of the plugin will remain the
same whilst opensearchDashboardsVersion in the opensearch_dashboards.json
will be the OpenSearch Dashboards version, eg, 1.3.0-alpha1. This is why
the version check needed to be modified a little to ensure that it can
get the version + qualifier and the default version of the plugin.

Updated for plugins as well.

Was able to successfully build and connect OSD 1.3.0-alpha1 to
the release version of OS 1.3.0.

Issue resolved:
opensearch-project/OpenSearch-Dashboards#1340

Issue partially resolved:
opensearch-project#1632

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/opensearch-build that referenced this issue Mar 29, 2022
Support version qualifier builds for OpenSearch Dashboards and
OpenSearch Dashboards Plugins.

This will create a zip for plugins with the OpenSearch Dashboards
version + qualifier. But the version of the plugin will remain the
same whilst opensearchDashboardsVersion in the opensearch_dashboards.json
will be the OpenSearch Dashboards version, eg, 1.3.0-alpha1. This is why
the version check needed to be modified a little to ensure that it can
get the version + qualifier and the default version of the plugin.

Updated for plugins as well.

Was able to successfully build and connect OSD 1.3.0-alpha1 to
the release version of OS 1.3.0.

Issue resolved:
opensearch-project/OpenSearch-Dashboards#1340

Issue partially resolved:
opensearch-project#1632

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla
Copy link
Member

kavilla commented Mar 29, 2022

Resolved with: opensearch-project/opensearch-build#1836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.0.0
Projects
None yet
Development

No branches or pull requests

2 participants