Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] --rpm does not actually build RPM artifact #1259

Closed
peterzhuamazon opened this issue Feb 17, 2022 · 6 comments · Fixed by #1285 or #1305
Closed

[BUG] --rpm does not actually build RPM artifact #1259

peterzhuamazon opened this issue Feb 17, 2022 · 6 comments · Fixed by #1285 or #1305
Assignees
Labels
bug Something isn't working v1.3.0

Comments

@peterzhuamazon
Copy link
Member

Using this on branch 1.x does not build .rpm package.

yarn build-platform --rpm --release

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/1.x/src/dev/build/cli.ts

It will build tarball and put it to target folder:

....../OpenSearch-Dashboards/target/opensearch-dashboards-1.3.0-linux-x64.tar.gz

Also, there is no option to build arm64 rpm as well.

Thanks.

@peterzhuamazon
Copy link
Member Author

cc: @bbarani

@peterzhuamazon
Copy link
Member Author

The same applies to deb, tho rpm takes higher priority now.
Thanks.

@ananzh
Copy link
Member

ananzh commented Feb 18, 2022

@peterzhuamazon

Could run yarn build-platform --all-platforms or yarn build to get rpm/deb package. Result is below (using osd 1.2.0):

~/work/OpenSearch-Dashboards/target$ ls
opensearch-dashboards-1.2.0-SNAPSHOT-amd64.deb          opensearch-dashboards-1.2.0-SNAPSHOT-linux-arm64.tar.gz  opensearch-dashboards-1.2.0-SNAPSHOT-windows-x64.zip
opensearch-dashboards-1.2.0-SNAPSHOT-darwin-x64.tar.gz  opensearch-dashboards-1.2.0-SNAPSHOT-linux-x64.tar.gz    opensearch-dashboards-1.2.0-SNAPSHOT-x64.rpm

Currently, we don't have arm64 rpm. We only have x64 rpm. We could build a single platform using yarn build-platform --linux-x64. But now we don't have a separate cmd for building only deb/rpm package. Need to get them with argument --all-platforms . If want to limit building only rpm package, would do yarn build-platform --all-platforms --rpm or yarn build --rpm.

@kavilla
Copy link
Member

kavilla commented Feb 18, 2022

@peterzhuamazon, to expand on @ananzh said.

You can also run the following:

yarn build --rpm --skip-archives --release

I think this is the command you are looking for, it will build specifically the RPM build. build-platform would be supports Linux x64, Linux ARM, and Darwin.

@peterzhuamazon
Copy link
Member Author

Thanks @ananzh @kavilla I will try the rpm commands for x64.
How long would it take to add arm64 rpm builds for dashboards?
As that is also crucial for the rpm releases.

Thanks.

@peterzhuamazon peterzhuamazon added bug Something isn't working v1.3.0 labels Feb 18, 2022
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Feb 22, 2022
Build ARM64 for deb with the following commands:
yarn build --deb --skip-archives
yarn build --deb --skip-archives --release

Build ARM64 for rpm with the following commands:
yarn build --rpm --skip-archives
yarn build --rpm --skip-archives --release

Issue partially resolved:
opensearch-project#1259

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Feb 22, 2022
Build ARM64 for deb with the following commands:
yarn build --deb --skip-archives
yarn build --deb --skip-archives --release

Build ARM64 for rpm with the following commands:
yarn build --rpm --skip-archives
yarn build --rpm --skip-archives --release

Issue partially resolved:
opensearch-project#1259

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Feb 22, 2022

Just talked to the dashboards team member and have these outcomes: (@kavilla @ananzh @tianleh)

  1. @kavilla PR can build both x64 and arm64 [Build] Build ARM64 for deb and rpm #1272 but cannot build only one of them, requires changes in our build.sh to grep the specific ones. Also, need to backport it to 1.x branch if merged.
  2. The arm64 package currently still have aarch64 in the naming:
-rw-r--r-- 1  96967083 Feb 22 23:00 opensearch-dashboards-2.0.0-SNAPSHOT-aarch64.rpm
-rw-r--r-- 1        40 Feb 22 23:00 opensearch-dashboards-2.0.0-SNAPSHOT-aarch64.rpm.sha1.txt
-rw-r--r-- 1  97227223 Feb 22 23:00 opensearch-dashboards-2.0.0-SNAPSHOT-x64.rpm
-rw-r--r-- 1        40 Feb 22 23:00 opensearch-dashboards-2.0.0-SNAPSHOT-x64.rpm.sha1.txt
  1. Like OpenSearch, the Dashboards is bundling nodejs tarball within the rpm, need to make them as dependencies during installation time:
    https://www.softwarecollections.org/en/scls/?search=NodeJS
  2. Need someone from @seanneumann / @seraphjiang team to verify that the core dashboards rpm package is able to run on arm64 before Infra Team use it for bundled rpm creation.

Thanks,
Peter

kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Feb 24, 2022
Build ARM64 for deb with the following commands:
yarn build --deb-arm --skip-archives
yarn build --deb-arm --skip-archives --release

Build ARM64 for rpm with the following commands:
yarn build --rpm-arm --skip-archives
yarn build --rpm-arm --skip-archives --release

Issue partially resolved:
opensearch-project#1259

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Feb 25, 2022
Build ARM64 for deb with the following commands:
yarn build --deb-arm --skip-archives
yarn build --deb-arm --skip-archives --release

Build ARM64 for rpm with the following commands:
yarn build --rpm-arm --skip-archives
yarn build --rpm-arm --skip-archives --release

Issue partially resolved:
opensearch-project#1259

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla linked a pull request Feb 25, 2022 that will close this issue
7 tasks
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Feb 26, 2022
Build ARM64 for deb with the following commands:
yarn build --deb-arm --skip-archives
yarn build --deb-arm --skip-archives --release

Build ARM64 for rpm with the following commands:
yarn build --rpm-arm --skip-archives
yarn build --rpm-arm --skip-archives --release

Issue partially resolved:
opensearch-project#1259

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Feb 28, 2022
Build ARM64 for deb with the following commands:
yarn build --deb-arm --skip-archives
yarn build --deb-arm --skip-archives --release

Build ARM64 for rpm with the following commands:
yarn build --rpm-arm --skip-archives
yarn build --rpm-arm --skip-archives --release

Issue partially resolved:
opensearch-project#1259

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla self-assigned this Feb 28, 2022
kavilla added a commit that referenced this issue Mar 2, 2022
* [Build] Build ARM64 for deb and rpm

Build ARM64 for deb with the following commands:
yarn build --deb-arm --skip-archives
yarn build --deb-arm --skip-archives --release

Build ARM64 for rpm with the following commands:
yarn build --rpm-arm --skip-archives
yarn build --rpm-arm --skip-archives --release

Issue partially resolved:
#1259

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Mar 2, 2022
* [Build] Build ARM64 for deb and rpm

Build ARM64 for deb with the following commands:
yarn build --deb-arm --skip-archives
yarn build --deb-arm --skip-archives --release

Build ARM64 for rpm with the following commands:
yarn build --rpm-arm --skip-archives
yarn build --rpm-arm --skip-archives --release

Issue partially resolved:
#1259

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 5941044)
@kavilla kavilla linked a pull request Mar 2, 2022 that will close this issue
kavilla added a commit that referenced this issue Mar 3, 2022
* [Build] Build ARM64 for deb and rpm

Build ARM64 for deb with the following commands:
yarn build --deb-arm --skip-archives
yarn build --deb-arm --skip-archives --release

Build ARM64 for rpm with the following commands:
yarn build --rpm-arm --skip-archives
yarn build --rpm-arm --skip-archives --release

Issue partially resolved:
#1259

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 5941044)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.3.0
Projects
None yet
3 participants