Skip to content

Commit

Permalink
Temporary fix for a bug with Chrome 129 when handling mask-image (#8274
Browse files Browse the repository at this point in the history
…) (#8278)

* Temporary fix for a bug with Chrome 129 when handling mask-image



* Changeset file for PR #8274 created/updated

---------



(cherry picked from commit cd6a909)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
  • Loading branch information
3 people committed Sep 21, 2024
1 parent fdf733b commit cb366fa
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 0 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/8274.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Add a temporary fix for a bug with Chrome 129 when handling mask-image ([#8274](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8274))
28 changes: 28 additions & 0 deletions src/core/public/styles/_base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,31 @@ $euiCollapsibleNavWidth: $euiSize * 20;
height: auto;
width: auto;
}

// Temporary fix for a bug with Chrome 129 when handling mask-image
// OUI provides the mask-image used in these which Chrome 129 fails to render correctly.
// It is not known if or when Chrome will fix this. Since almost all of these classes
// are applied to elements with scrollbars where their content contained, containing the
// paint is a safe solution.
// This can be achieved with various tricks like transform: translate?(0) or
// transform-style: preserve-3d but they add to the browsers workload; contain doesn't.
// ToDo: Remove these when most used versions of Chrome no longer suffer from the bug.
// From OUI: any ruleset containing mask-image
.eui-yScrollWithShadows,
.eui-xScrollWithShadows,
.euiYScrollWithShadows,
.euiDataGrid__controlScroll,
.euiDataGridColumnSelector__columnList,
.euiDataGridColumnSorting__fieldList,
.euiFlyoutBody .euiFlyoutBody__overflow,
.euiFlyoutBody .euiFlyoutBody__overflow.euiFlyoutBody__overflow--hasBanner,
.euiModalBody .euiModalBody__overflow,
.euiSelectableList__list,
// For OSD: consumers of eui?ScrollWithShadows
.osdQueryBar__textarea:not(:focus):not(:invalid),
.osdSavedQueryManagement__list,
.dscCanvas,
.vbConfig,
.vbSidenav__style {
contain: paint;
}

0 comments on commit cb366fa

Please sign in to comment.