Skip to content

Commit

Permalink
Resolving comments
Browse files Browse the repository at this point in the history
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
  • Loading branch information
xinruiba committed Mar 4, 2024
1 parent ce49e74 commit c907071
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ import { EuiSuperSelectOption } from '@elastic/eui';
export interface AuthenticationMethod {
name: string;
credentialSourceOption: EuiSuperSelectOption<string>;
credentialForm?: (state?: any, setState?: any) => React.JSX.Element;
credentialForm?: (
state: { [key: string]: any },
setState: React.Dispatch<React.SetStateAction<any>>
) => React.JSX.Element;
crendentialFormField?: { [key: string]: string };
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,8 @@ export class CreateDataSourceForm extends React.Component<
if (authCredentialForm !== undefined) {
return authCredentialForm(this.state, this.handleStateChange);
}

return null;

Check warning on line 341 in src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/data_source_management/public/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx#L341

Added line #L341 was not covered by tests
};

/* Render methods */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,8 @@ export class EditDataSourceForm extends React.Component<EditDataSourceProps, Edi
if (authCredentialForm !== undefined) {
return authCredentialForm(this.state, this.handleStateChange);
}

return null;

Check warning on line 541 in src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/data_source_management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx#L541

Added line #L541 was not covered by tests
};

/* Render methods */
Expand Down

0 comments on commit c907071

Please sign in to comment.