update per PR comments

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
opensearch-project · Oct 13, 2023 · a21adee · a21adee
1 parent 018395f
commit a21adee
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/core/public/index.ts b/src/core/public/index.ts
@@ -348,4 +348,4 @@ export {
 
 export { __osdBootstrap__ } from './osd_bootstrap';
 
-export { WorkspacesStart, WorkspacesSetup, WorkspacesService } from './workspace';
+export { WorkspacesStart, WorkspacesSetup } from './workspace';
diff --git a/src/core/public/workspace/workspaces_service.ts b/src/core/public/workspace/workspaces_service.ts
@@ -27,7 +27,8 @@ interface WorkspaceObservables {
 
   /**
    * The list of available workspaces. This workspace list should be set by whoever
-   * the workspace functionalities
+   * implemented the workspace functionalities, core workspace module should not be
+   * aware of how to populate the workspace list.
    */
   workspaceList$: BehaviorSubject<WorkspaceObject[]>;
 
@@ -39,7 +40,7 @@ interface WorkspaceObservables {
 }
 
 enum WORKSPACE_ERROR {
-  WORKSPACE_STALED = 'WORKSPACE_STALED',
+  WORKSPACE_IS_STALE = 'WORKSPACE_IS_STALE',
 }
 
 export type WorkspacesSetup = WorkspaceObservables;
@@ -66,13 +67,13 @@ export class WorkspacesService implements CoreService<WorkspacesSetup, Workspace
 
           if (currentWorkspaceId && !currentWorkspace?.id) {
             /**
-             * Current workspace is staled
+             * Current workspace is stale
              */
             this.currentWorkspaceId$.error({
-              reason: WORKSPACE_ERROR.WORKSPACE_STALED,
+              reason: WORKSPACE_ERROR.WORKSPACE_IS_STALE,
             });
             this.currentWorkspace$.error({
-              reason: WORKSPACE_ERROR.WORKSPACE_STALED,
+              reason: WORKSPACE_ERROR.WORKSPACE_IS_STALE,
             });
           }
         }

diff --git a/src/core/types/workspace.ts b/src/core/types/workspace.ts
@@ -10,6 +10,5 @@ export interface WorkspaceAttribute {
   features?: string[];
   color?: string;
   icon?: string;
-  defaultVISTheme?: string;
   reserved?: boolean;
 }