Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abstractda): add val manipulation capability #275

Merged
merged 11 commits into from
Aug 3, 2021

Conversation

JakobVogelsang
Copy link
Collaborator

@JakobVogelsang JakobVogelsang commented Jul 31, 2021

Closes #274
Closes #280
Closes #279

This PR does not only add basic Val manipulation capability but also dchg, qchg and dupd - last three attributes of DA. I also found the pattern for the name of both BDA and DA was not correct.
I also take the chance and pushed the touched wizards to the wizard library.

@JakobVogelsang JakobVogelsang self-assigned this Jul 31, 2021
@JakobVogelsang JakobVogelsang marked this pull request as ready for review July 31, 2021 21:30
@JakobVogelsang JakobVogelsang requested a review from ca-d July 31, 2021 21:30
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks and reads extremely well. The only thing that sticks out to me is the foundation.ts directory name which looks like a TypeScript file.

src/wizard-select.ts Show resolved Hide resolved
src/wizards/abstractda.ts Show resolved Hide resolved
src/wizards/bda.ts Show resolved Hide resolved
src/wizards/foundation.ts/enums.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ca-d ca-d merged commit 259ce39 into main Aug 3, 2021
@ca-d ca-d deleted the add-val-manipulation-capability branch August 3, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants