Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(templates/lnodetype-wizards): add helper wizard for missing lnClass in templates #241

Merged
merged 6 commits into from
Jul 8, 2021
Merged

feat(templates/lnodetype-wizards): add helper wizard for missing lnClass in templates #241

merged 6 commits into from
Jul 8, 2021

Conversation

JakobVogelsang
Copy link
Collaborator

Closes #223

@JakobVogelsang JakobVogelsang added this to the Sprint 2021-07-16 milestone Jul 6, 2021
@JakobVogelsang JakobVogelsang marked this pull request as ready for review July 7, 2021 08:43
@JakobVogelsang JakobVogelsang requested a review from ca-d July 7, 2021 08:43
@JakobVogelsang
Copy link
Collaborator Author

JakobVogelsang commented Jul 7, 2021 •
edited
Loading

@ca-d I slightly changed this task and introduced an autoimport option. With this option, we separate the import from templates from the guided creation based on *.nsd files.

ca-d
ca-d approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/editors/templates/lnodetype-wizard.ts Outdated Show resolved Hide resolved
src/editors/templates/lnodetype-wizard.ts Outdated Show resolved Hide resolved
src/editors/templates/lnodetype-wizard.ts Outdated Show resolved Hide resolved
src/editors/templates/lnodetype-wizard.ts Outdated Show resolved Hide resolved
@ca-d
Copy link
Contributor

ca-d commented Jul 7, 2021

We could also:

  • move dialogInitialFocus to LN Class mwc-select
  • remove numbers from LN CLass select
  • sort lowercased string matching DOTypes upwards in select menu
  • sort DOType selects themselves by required
  • move the predefined template toggle button to the bottom and disable it instead of hiding it

@JakobVogelsang JakobVogelsang merged commit 07c8b3e into main Jul 8, 2021
@ca-d ca-d deleted the lnodetype-creation-helper-wizard branch July 10, 2021 20:50
Stef3st pushed a commit that referenced this pull request Nov 2, 2023
@juancho0202
Merge pull request #241 from com-pas/dependabot/github_actions/action…
b7ffb36 
…s/setup-node-3

chore(deps): bump actions/setup-node from 1 to 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ca-d ca-d ca-d approved these changes

Assignees
No one assigned
Labels
Kind: Enhancement New Request Priority: Important Tackle eventually
Projects
None yet
Milestone
Sprint 2021-07-16
Development

Successfully merging this pull request may close these issues.

LNodeType creation helper wizards
2 participants
@JakobVogelsang @ca-d