Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic dotype manipulation capability #209

Merged
merged 18 commits into from
Jun 11, 2021
Merged

Add basic dotype manipulation capability #209

merged 18 commits into from
Jun 11, 2021

Conversation

JakobVogelsang
Copy link
Collaborator

@JakobVogelsang JakobVogelsang commented Jun 5, 2021 •
edited
Loading

Closes #91

@JakobVogelsang JakobVogelsang added this to the Sprint 2021-06-11 milestone Jun 5, 2021
@JakobVogelsang JakobVogelsang force-pushed the add-basic-dotype-manipulation-capability branch from ff67b69 to 67a9334 Compare June 7, 2021 13:26
@JakobVogelsang JakobVogelsang changed the base branch from show-dotype-in-filtered-list to main June 7, 2021 15:58
@JakobVogelsang JakobVogelsang marked this pull request as ready for review June 7, 2021 15:58
@JakobVogelsang JakobVogelsang requested a review from ca-d June 7, 2021 15:58
JakobVogelsang and others added 14 commits June 11, 2021 17:13
@JakobVogelsang @ca-d
feat(editors/dotype-wizard): add dOTypeWizard
408b58a
@JakobVogelsang @ca-d
fix(translate): german translation
92a7af3
@JakobVogelsang @ca-d
feat(public/templates): add some DOType elements
19c725b
@JakobVogelsang @ca-d
feat(editors/dotype-wizards): add wizard to create add DOType from te…
3773073 
…mplate
@JakobVogelsang @ca-d
fix(editors/dotype-wizard): create DOType specific update action
3d66a60
@JakobVogelsang @ca-d
feat(editors/dotype-wizard): add sDOWizard and dAWizard
85c28b1
@JakobVogelsang @ca-d
test(editors/dotype-wizard): add createDOTypeWizard intgration tests
83a8572
@JakobVogelsang @ca-d
test(editors/datype-wizards): fix snapshot
abdd7ca
@ca-d
fix(translations): add missing translations
f2b7482
@ca-d
test(editors/datype-dotype-wizard): update snapshots
c54f734
@ca-d
test(editors/dotype-wizards): add more integration tests
e7e8f72
@ca-d
test(editors/dotype-wizard): add missing dotype.scd
c8ab6da
@ca-d
test(editors/dotype-wizard): make test more save
234d1dc
@ca-d
feat(editors/dotype-wizard): add functional constraints selector
86bfeaa
@ca-d ca-d force-pushed the add-basic-dotype-manipulation-capability branch from 25bd508 to 86bfeaa Compare June 11, 2021 15:13
ca-d
ca-d suggested changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one missing translation, looks very good to me otherwise, clean code and an easy read.

src/editors/templates/dotype-wizards.ts Outdated Show resolved Hide resolved
JakobVogelsang and others added 2 commits June 11, 2021 17:39
@JakobVogelsang
feat(editors/templates): add read-only LNodeType filtered-list (#212)
5aab8ec
@ca-d
fix(dotype-wizards): translate mwc-select helper (#214)
1b00bf5 
* fix(dotype-wizards): translate mwc-select helper

* fix(translations/en): add helper translation

* fix(translations/de): add helper translation
@ca-d ca-d self-requested a review June 11, 2021 15:49
ca-d
ca-d approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ca-d ca-d merged commit e21f237 into main Jun 11, 2021
@ca-d ca-d deleted the add-basic-dotype-manipulation-capability branch June 11, 2021 16:02
@ca-d ca-d added Kind: Enhancement New Request and removed Kind: Feature labels Jul 29, 2021
pascalwilbrink pushed a commit that referenced this pull request Sep 11, 2023
Merge pull request #209 from com-pas/upgrade-websocket-validator
0c7246b 
Update validator call for websockets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ca-d ca-d ca-d approved these changes

Assignees
No one assigned
Labels
Kind: Enhancement New Request Priority: Important Tackle eventually
Projects
None yet
Milestone
Sprint 2021-06-11
Development

Successfully merging this pull request may close these issues.

Create basic DOType manipulation capability
2 participants
@JakobVogelsang @ca-d