Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(communicationmapping): ClientLN handling for LNs reside in AccessPoint #173

Merged
merged 2 commits into from
Apr 24, 2021
Merged

fix(communicationmapping): ClientLN handling for LNs reside in AccessPoint #173

merged 2 commits into from
Apr 24, 2021

Conversation

JakobVogelsang
Copy link
Collaborator

@JakobVogelsang JakobVogelsang commented Apr 14, 2021 •
edited by ca-d
Loading

Closes #171 .

@JakobVogelsang JakobVogelsang added Kind: Bug Something isn't working Reviewed: Prioritized Priority: Important Tackle eventually labels Apr 14, 2021
@JakobVogelsang JakobVogelsang added this to the Sprint 2021-04-30 milestone Apr 15, 2021
ca-d
ca-d approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix LGTM, but CommunicationMapping looks like it could use some more refactoring in general.

@JakobVogelsang JakobVogelsang merged commit 0fce19e into main Apr 24, 2021
@ca-d ca-d deleted the fix-invalid-clientln-handling branch April 28, 2021 07:00
pascalwilbrink pushed a commit that referenced this pull request Sep 11, 2023
Merge pull request #173 from com-pas/upstream-v0.20.0
fb4ea0a 
Merged v0.20.0 of OpenSCD to CoMPAS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ca-d ca-d ca-d approved these changes

Assignees
No one assigned
Labels
Kind: Bug Something isn't working Priority: Important Tackle eventually
Projects
None yet
Milestone
Sprint 2021-04-30
Development

Successfully merging this pull request may close these issues.

Duplicate ClientLN
2 participants
@JakobVogelsang @ca-d