Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Added ConfDataSet to the Services Wizard #1332

Merged
merged 8 commits into from
Nov 13, 2023
Merged

Chore: Added ConfDataSet to the Services Wizard #1332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
69cbd7a
Chore: Added ConfDataSet to the Services Wizard
pascalwilbrink Oct 18, 2023
d776f94
Fixed typo, added snapshot
pascalwilbrink Oct 18, 2023
bb22045
Fixed review comments
pascalwilbrink Oct 31, 2023
dee8643
Merge branch 'main' into Add_ConfDataSet_To_Services
pascalwilbrink Oct 31, 2023
a0c92f4
Fixed merge conflict
pascalwilbrink Oct 31, 2023
44096a5
Removed dist folders
pascalwilbrink Nov 2, 2023
96c3c8e
Merge branch 'main' into Add_ConfDataSet_To_Services
pascalwilbrink Nov 2, 2023
180e91c
Merge branch 'main' into Add_ConfDataSet_To_Services
pascalwilbrink Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion packages/open-scd/src/wizards/service-log-settingsgroup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,19 @@ interface SGEdit {
interface ConfSG {
resvTms: string | null;
}

interface DataSet {
max: string | null;
maxAttributes: string | null;
modify: string | null;
}
interface ContentOptions {
logSettings: LogSettings;
confLogControl: ConfLogControl;
clientServices: ClientServices;
sGEdit: SGEdit;
confSG: ConfSG;
dataSet: DataSet;
}

export function createLogSettingsGroupServicesWizardPage(
Expand Down Expand Up @@ -73,9 +80,21 @@ function createLogSettingsGroupServicesWizard(
confLogControl: {
max: parent.querySelector('ConfLogControl')?.getAttribute('max') ?? null,
},
dataSet: {
max:
parent.querySelector('ConfDataSet')?.getAttribute('max') ??
Array.from(
parent.parentElement?.querySelectorAll('DataSet') || []
).length.toString(),
maxAttributes:
parent.querySelector('ConfDataSet')?.getAttribute('maxAttributes') ??
null,
modify:
parent.querySelector('ConfDataSet')?.getAttribute('modify') ?? 'true',
},
clientServices: {
readLog:
parent.querySelector('CientServices')?.getAttribute('readLog') ?? null,
parent.querySelector('ClientServices')?.getAttribute('readLog') ?? null,
},
sGEdit: {
resvTms:
Expand Down Expand Up @@ -169,6 +188,29 @@ function createLogSettingsGroupServicesWizard(
maybeValue: content.clientServices.readLog,
},
]),
createFormDivider('DataSet Configuration'),
...createFormElementsFromInputs([
{
kind: 'TextField',
label: 'Max',
nullable: false,
helper: 'The maximum allow data sets in this IED',
maybeValue: content.dataSet.max,
},
{
kind: 'TextField',
label: 'Max attributes',
nullable: true,
helper: 'The maximum number of FCDA elements per DataSet',
maybeValue: content.dataSet.maxAttributes,
},
{
kind: 'Checkbox',
label: 'Modify',
helper: 'Whether DataSet can be modified by SCT',
maybeValue: content.dataSet.modify,
},
]),
createFormDivider('Setting Group'),
...createFormElementsFromInputs([
{
Expand Down
Loading